(refactor): CMB2 'show on' taxonomy field type from 'select_advanced'…

… to 'taxonomy_multicheck'
OpenWebconcept · Apr 26, 2024 · 9df8fe1 · 9df8fe1
1 parent bf21911
commit 9df8fe1
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.4.4
+
+- Refactor: CMB2 'show on' taxonomy field type from 'select_advanced' to 'taxonomy_multicheck'
+
 ## v3.4.3
 
 - Chore: Updated CMB2 to version 2.11.0

diff --git a/config/show_on_metabox.php b/config/show_on_metabox.php
@@ -2,25 +2,22 @@
 
 return [
     'show_on' => [
-        'id'         => 'show_on',
-        'title'      => __('External', 'openpub-base'),
+        'id' => 'show_on',
+        'title' => __('External', 'openpub-base'),
         'object_types' => ['openpub-item'],
-        'context'    => 'normal',
-        'priority'   => 'low',
-        'autosave'   => true,
-        'fields'     => [
+        'context' => 'normal',
+        'priority' => 'low',
+        'autosave' => true,
+        'fields' => [
             'settings' => [
                 [
-                    'name'       => __('Show on', 'openpub-base'),
-                    'desc'       => __('Select websites where this item should be displayed on.', 'openpub-base'),
-                    'id'         => 'show_on_active',
-                    'type'       => 'taxonomy_select',
-                    'taxonomy'   => 'openpub-show-on',
-                    'field_type' => 'select_advanced',
-                    'required'   => 1,
-                    'multiple'   => 1
+                    'name' => __('Show on', 'openpub-base'),
+                    'desc' => __('Select websites where this item should be displayed on.', 'openpub-base'),
+                    'id' => 'show_on_active',
+                    'type' => 'taxonomy_multicheck',
+                    'taxonomy' => 'openpub-show-on',
                 ],
-            ]
-        ]
-    ]
+            ],
+        ],
+    ],
 ];
diff --git a/openpub-base.php b/openpub-base.php
@@ -4,7 +4,7 @@
  * Plugin Name:       Yard | OpenPub Base
  * Plugin URI:        https://www.openwebconcept.nl/
  * Description:       Acts as foundation for other OpenPub related content plugins. This plugin implements actions to allow for other plugins to add and/or change Custom Posttypes, Metaboxes, Taxonomies, en Posts 2 posts relations.
- * Version:           3.4.3
+ * Version:           3.4.4
  * Author:            Yard | Digital Agency
  * Author URI:        https://www.yard.nl/
  * License:           GPL-3.0
@@ -16,7 +16,7 @@
 /**
  * If this file is called directly, abort.
  */
-if (!defined('WPINC')) {
+if (! defined('WPINC')) {
     die;
 }
 

diff --git a/src/Base/Foundation/Plugin.php b/src/Base/Foundation/Plugin.php
@@ -19,7 +19,7 @@ class Plugin
      * Version of the plugin.
      * Used for setting versions of enqueue scripts and styles.
      */
-    public const VERSION = '3.4.3';
+    public const VERSION = '3.4.4';
 
     /**
      * Path to the root of the plugin.
@@ -155,7 +155,7 @@ public function callServiceProviders(string $method, string $key = ''): void
 
             $service = new $service($this);
 
-            if (!$service instanceof ServiceProvider) {
+            if (! $service instanceof ServiceProvider) {
                 throw new \Exception('Provider must be an instance of ServiceProvider.');
             }
 

diff --git a/src/Base/Metabox/MetaboxServiceProvider.php b/src/Base/Metabox/MetaboxServiceProvider.php
@@ -10,7 +10,7 @@
 class MetaboxServiceProvider extends ServiceProvider
 {
     public const PREFIX = '_owc_';
-    
+
     public function register()
     {
         $this->plugin->loader->addAction('cmb2_admin_init', $this, 'registerMetaboxes', 10, 0);
@@ -25,7 +25,7 @@ public function register()
     public function registerMetaboxes(): void
     {
         $configMetaboxes = $this->plugin->config->get('cmb2_metaboxes');
-        
+
         if (! is_array($configMetaboxes)) {
             return;
         }
@@ -77,7 +77,7 @@ protected function registerMetaboxFields(CMB2 $metabox, array $fields): void
     {
         foreach ($fields as $field) {
             $fieldKeys = array_keys($field);
-            
+
             foreach ($fieldKeys as $fieldKey) {
                 if (! is_array($field[$fieldKey])) {
                     continue;