Bump foundry to 0.28.0 #1112
Closed
Bump foundry to 0.28.0 #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immrsd
reviewed
Aug 26, 2024
| @@ -120,6 +120,9 @@ A module containing utilities that simplify declaring and deploying contracts us | |||
|
|
|||
| Declares a contract with a `snforge` `declare` call and unwraps the result. | |||
|
|
|||
| NOTE: If the contract is already declared, this function won't panic but will instead | |||
| return the existing class. | |||
|
|
|||
| @@ -50,7 +52,7 @@ fn setup(key_pair: StarkKeyPair) -> ComponentState { | |||
| fn setup_dispatcher( | |||
| key_pair: StarkKeyPair, data: SignedTransactionData | |||
| ) -> (AccountABIDispatcher, felt252) { | |||
| let contract_class = declare("DualCaseAccountMock").unwrap_syscall(); | |||
| let contract_class = *declare("DualCaseAccountMock").unwrap_syscall().contract_class(); | |||
There was a problem hiding this comment.
We could use utils::declare_class here, that would make the code a bit more concise and we wouldn't have to import DeclareResultTrait
|
Since the release has some issues with test collection, let's wait for the fix before updating and merging this PR. |
Co-authored-by: immrsd <[email protected]>
|
Closing in favor of #1137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1111
PR Checklist