Add ERC7821 to Account.sol #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
reviewed
Dec 20, 2024
Amxx
force-pushed
the
aa/executeUserOp-delegate
branch
from
88e7eb0 to
113f9c9
Compare
Amxx
force-pushed
the
aa/executeUserOp-delegate
branch
from
113f9c9 to
42906dc
Compare
Amxx
changed the title
Amxx
changed the title
ernestognw
reviewed
Dec 23, 2024
contracts/account/AccountCore.sol
Outdated
| // we cannot use `Address.functionCallWithValue` here as it would revert on EOA targets | ||
| (bool success, bytes memory returndata) = target.call{value: value}(data); | ||
| Address.verifyCallResult(success, returndata); | ||
| Address.functionDelegateCall(address(this), userOp.callData[4:]); |
There was a problem hiding this comment.
I think the best option right now is to get rid of this function. The Account.sol won't be able to send individual calls anyway and the IAccountExecute interface is optional.
I understand someone may want to use this function to validate userOp fields, but I don't see that as common. At this point I'd just remove it and leave ERC7821
ernestognw
previously approved these changes
Dec 23, 2024
ernestognw
previously approved these changes
Dec 24, 2024
ernestognw
previously approved these changes
Dec 24, 2024
ernestognw
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52 by implementing ERC7821 (without the optional opData) for batch tx processing