feat(shared-data): add flex stacker addressable area to deck definition #17204
+108
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the addressable areas for the stacker to the deck definition. This also includes adding the most delightful fixtures that are the
flexStackerV1WithWasteChuteRightAdapterNoCoverandflexStackerV1WithWasteChuteRightAdapterNoCoverso we can use the stacker next to a trash chute.Side note
I found out that the deck definition hasn't been matching the schema. Specifically, the
areaTypeenums for the modules are all missing... So i added them here.Though this means the
areaTypefield doesn't really do much of anything, it raises the question if we should validate our definitions against the schemas more diligently. Like, adding CI checks?