Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix version and missing files. #147

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

dany-pellerin
Copy link
Contributor

@dany-pellerin dany-pellerin commented Dec 5, 2024

This PR fixes 2 issues that happened with the latest release:

  • Version in the build.json needs to be patched before building (and also before publishing). The build step copies the build.json file which needs to be patched before running the command.
  • There are subfolders in the dist and not all files were included in the build artifact. Because of that not all artifacts were uploaded in the npm package

@dany-pellerin dany-pellerin requested a review from zapo December 5, 2024 19:06
@dany-pellerin dany-pellerin self-assigned this Dec 5, 2024
@dany-pellerin dany-pellerin force-pushed the fix-version-missing-files branch from 366f927 to 2d26f7b Compare December 5, 2024 19:15
@dany-pellerin dany-pellerin merged commit 4fd09f5 into master Dec 5, 2024
7 checks passed
@dany-pellerin dany-pellerin deleted the fix-version-missing-files branch December 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants