-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy 122 - Yield Forwarding from Curve Pool. #2377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
=======================================
Coverage 50.80% 50.80%
=======================================
Files 92 92
Lines 4513 4513
Branches 1195 1195
=======================================
Hits 2293 2293
Misses 2217 2217
Partials 3 3 ☔ View full report in Codecov by Sentry. |
shahthepro
previously approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
All deployed contracts are listed in the deploy PR's description- No contracts deployed
-
Deployed contract's verified code (and all dependencies) match the code in master -
Contract constructors have correct arguments -
The transactions that interacted with the newly deployed contract match the deploy script. - Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
|
sparrowDom
previously approved these changes
Feb 3, 2025
69b3765
sparrowDom
approved these changes
Feb 3, 2025
shahthepro
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deployment:
Deploy script:
122_delegate_yield_curve_pool.js
Governance
Proposal Id:
60064990355804217476059907885755104273895299069162020298218568486004603846351
Proposal tx: 0xa9f8e2fcee32214f567a5f37e7fbd40803d44b611e52def7608e1865e464428e
Proposal Payload
Code Change Checklist
Deploy checklist
Two reviewers complete the following checklist: