Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 122 - Yield Forwarding from Curve Pool. #2377

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Feb 3, 2025

Description

Deployment:

Deploy script:

  • 122_delegate_yield_curve_pool.js

Governance

Proposal Id: 60064990355804217476059907885755104273895299069162020298218568486004603846351
Proposal tx: 0xa9f8e2fcee32214f567a5f37e7fbd40803d44b611e52def7608e1865e464428e

Proposal Payload

[
  [
    "0x2A8e1E676Ec238d8A992307B495b45B3fEAa5e86"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "delegateYield(address,address)"
  ],
  [
    "0x00000000000000000000000037715d41ee0af05e77ad3a434a11bbff473efe41000000000000000000000000f4c001dfe53c584425d7943395c7e57b10bd1dc8"
  ]
]

Code Change Checklist

  • No code

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.80%. Comparing base (aca54e1) to head (69b3765).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2377   +/-   ##
=======================================
  Coverage   50.80%   50.80%           
=======================================
  Files          92       92           
  Lines        4513     4513           
  Branches     1195     1195           
=======================================
  Hits         2293     2293           
  Misses       2217     2217           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clement-ux clement-ux changed the title feat: proposal for Yield Forwarding Curve Pool. Deploy 122 - Yield Forwarding from Curve Pool. Feb 3, 2025
shahthepro
shahthepro previously approved these changes Feb 3, 2025
Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
    • No contracts deployed
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

@sparrowDom
Copy link
Member

  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

sparrowDom
sparrowDom previously approved these changes Feb 3, 2025
@clement-ux clement-ux dismissed stale reviews from sparrowDom and shahthepro via 69b3765 February 3, 2025 14:24
@naddison36 naddison36 added the deployment Deploying smart contract label Feb 6, 2025
@naddison36 naddison36 merged commit d557ad3 into master Feb 10, 2025
15 of 19 checks passed
@naddison36 naddison36 deleted the clement/delegate-yield-to-curve-pool branch February 10, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deploying smart contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants