Redefine Curve AMO Abstract structure. #2379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
requested review from
sparrowDom,
DanielVF,
naddison36 and
shahthepro
as code owners
|
we've decided to not go for this because:
overall the abstraction benefits do not outweigh the downsides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to change how Curve AMO contract are structured.
!This is experimental!
Instead of having multiple contract, re-implementing AMO logic, the logic will be stored in a Abstract contract: "AbstractCurveAMOStrategy".
And all Curve AMO should inherit this abstract contract.
The logic (eg. where to deposit LP or how to get LP) will be done on the main contract instead, by overriding not defined functions like:
_addLiquidity_removeLiquidity_removeLiquidityOneCoin_stakeLP_unstakeLP_wrapETH_unwrapETH_claimReward_approveBase_getBalances_solvencyAssertmaxSlippage