-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperOETH Harvester #2398
SuperOETH Harvester #2398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
==========================================
- Coverage 51.31% 49.57% -1.74%
==========================================
Files 92 94 +2
Lines 4529 4714 +185
Branches 1203 1251 +48
==========================================
+ Hits 2324 2337 +13
- Misses 2201 2373 +172
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, very clean 👍
Code Changes
SuperOETHHarvester
that inherits fromOETHHarvesterSimple
.SuperOETHHarvester
and all native LST OTokens (OETH) to useOETHHarvesterSimple
weth
inOETHHarvesterSimple
towrappedNativeToken
to avoid confusions when using for wS on SonicOETHBaseHarvester
is no longer used (I'm splitting up the swap functions to a Safe module in a different branch to help with our operations better)OETHBaseHarvester
, however the deployment file callsinitialize
and that should reset the slots