[OETHb] Deploy 026 - Deploy Harvester 2.0

[shahthepro]

Contract Deployment

Contract	Address
SuperOETHHarvester (implementation)	0x8d840080f57BcD698941631817694d896Ac8F9Fa

Governance

Check files under contracts/deployments/base/operations for the generated JSON files.

Actions:

• Upgrades the existing OETHBaseHarvesterProxy with the new deployed contract
• Initializes the proxy (essentially resets the storage slots)
• Whitelists the strategies
• Sets the harvester address on Curve AMO strategy

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.57%. Comparing base (83b8790) to head (1d24507).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2399   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files          94       94           
  Lines        4714     4714           
  Branches     1251     1251           
=======================================
  Hits         2337     2337           
  Misses       2373     2373           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sparrowDom]

• All deployed contracts are listed in the deploy PR's description
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
• The transactions that interacted with the newly deployed contract match the deploy script.
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal

npx sol2uml diff 0x8d840080f57BcD698941631817694d896Ac8F9Fa .,node_modules -n base
Compared the "SuperOETHHarvester" contract with address 0x8d840080f57BcD698941631817694d896Ac8F9Fa on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/governance/Strategizable.sol
match   contracts/harvest/OETHHarvesterSimple.sol
match   contracts/harvest/SuperOETHHarvester.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/utils/Initializable.sol

[clement-ux]

• All deployed contracts are listed in the deploy PR's description
  • SuperOETHHarvester Implementation
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
  • SuperOETHHarvester: WETH
• The transactions that interacted with the newly deployed contract match the deploy script.
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal

Diff checker

sol2uml diff 0x8d840080f57BcD698941631817694d896Ac8F9Fa .,node_modules -n base
(node:14011) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "SuperOETHHarvester" contract with address 0x8d840080f57BcD698941631817694d896Ac8F9Fa on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/governance/Strategizable.sol
match   contracts/harvest/OETHHarvesterSimple.sol
match   contracts/harvest/SuperOETHHarvester.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/utils/Initializable.sol