add option to not generate patches for common libraries #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea was that these libraries wouldn't do anything on their own, but mods could take advantage of their features. If there are any that do change vanilla behavior in some way, I'd rather downgrade them or remove them entirely. |
|
ok, if ornithe 1.0-1.2.5 ever gets allowed for speedrun.com/mc i'll just maintain my own instances then. should i make a separate pr for the first & third commits? |
|
that sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
good for testing if you don't want to rely on these libraries, or you want to stick closer to vanilla for whatever reason (speedrunning, etc)
libraries are added by default, this just lets the user disable that