Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launcher Java detection #16

Merged
merged 17 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
name: Release
on: [workflow_dispatch] # Manual trigger
on: [ workflow_dispatch ] # Manual trigger
jobs:
buildJava:
runs-on: ubuntu-20.04
container:
image: openjdk:17-jdk
options: --user root
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: gradle/wrapper-validation-action@v1
- run: ./gradlew build publish --stacktrace
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'microsoft'
java-version: 17
cache: 'gradle'
- uses: gradle/actions/wrapper-validation@v3
- name: Grant execute permission for Gradle wrapper
run: chmod +x ./gradlew
- run: ./gradlew assemble publish --stacktrace
env:
MAVEN_URL: ${{ secrets.NEW_MAVEN_URL }}
MAVEN_USERNAME: ${{ secrets.NEW_MAVEN_USERNAME }}
Expand All @@ -24,21 +28,22 @@ jobs:
strategy:
matrix:
target: [ x86_64, i686, aarch64 ]
runs-on: windows-2019
runs-on: windows-latest
steps:
# TODO: Fix macOS in future
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- run: rustup target add ${{ matrix.target }}-pc-windows-msvc
- uses: actions/setup-java@v2
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
distribution: 'microsoft'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
- run: ./gradlew build copyForNative
cache: 'gradle'
- uses: gradle/actions/wrapper-validation@v3
- run: ./gradlew assemble copyForNative
- name: Run Cargo
run: cargo build --release --target ${{ matrix.target }}-pc-windows-msvc
working-directory: ./native
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: Artifacts ${{ matrix.target }}
path: target/${{ matrix.target }}-pc-windows-msvc/release/quilt-installer.exe
Expand Down
37 changes: 20 additions & 17 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,31 +1,34 @@
name: Test
on: [push, pull_request]
on: [ push, pull_request ]
jobs:
build:
strategy:
matrix:
java: [17-jdk]
runs-on: ubuntu-20.04
container:
image: openjdk:${{ matrix.java }}
options: --user root
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: gradle/wrapper-validation-action@v1
- run: ./gradlew build test --stacktrace
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'microsoft'
java-version: 17
cache: 'gradle'
- uses: gradle/actions/wrapper-validation@v3
- name: Grant execute permission for Gradle wrapper
run: chmod +x ./gradlew
- run: ./gradlew build --stacktrace

buildNatives:
strategy:
matrix:
target: [ x86_64, i686, aarch64 ]
runs-on: windows-2019
runs-on: windows-latest
steps:
# TODO: Fix macOS in future
- uses: actions/checkout@v2
- uses: actions/setup-java@v2
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
distribution: 'microsoft'
java-version: 17
cache: 'gradle'
- uses: gradle/actions/wrapper-validation@v3
- run: ./gradlew build copyForNative --stacktrace
- run: rustup target add ${{ matrix.target }}-pc-windows-msvc
- name: Run Cargo
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# 0.9.2

- Fix download URLs for Java 21 runtime
25 changes: 19 additions & 6 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ version = if (env["SNAPSHOTS_URL"] != null) {
} else {
"0.10.2"
}
base.archivesBaseName = project.name

base {
archivesName.set(project.name)
}

repositories {
mavenCentral()
Expand All @@ -28,6 +31,10 @@ repositories {
}
}

sourceSets {
create("java8")
}

dependencies {
implementation("org.quiltmc.parsers:json:0.2.1")
compileOnly("org.jetbrains:annotations:20.1.0")
Expand All @@ -46,9 +53,11 @@ blossom {
}

tasks.compileJava {
if (JavaVersion.current().isJava9Compatible) {
options.release.set(17)
}
options.release.set(17)
}

tasks.getByName("compileJava8Java", JavaCompile::class) {
options.release.set(8)
}
java {
toolchain {
Expand All @@ -61,24 +70,28 @@ java {
// mainClass.set("org.quiltmc.installer.Main")
//}

tasks.jar.get().dependsOn(tasks["compileJava8Java"])
tasks.jar {
manifest {
attributes["Implementation-Title"] = "Ornithe-Installer"
attributes["Implementation-Version"] = project.version
attributes["Multi-Release"] = true

attributes["Main-Class"] = "org.quiltmc.installer.Main"
}
}

tasks.shadowJar {
relocate("org.quiltmc.parsers.json", "org.quiltmc.installer.lib.parsers.json")
minimize()
// minimize()

// Compiler does not know which set method we are targeting with null value
val classifier: String? = null;
archiveClassifier.set(classifier)
from(sourceSets["java8"].output)
}

tasks.build {
tasks.assemble {
dependsOn(tasks.shadowJar)
}

Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 3 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading
Loading