fix textarea default value not set

Osiris-Team · Aug 7, 2024 · f2ac228 · f2ac228
1 parent b36a98f
commit f2ac228
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/main/java/com/osiris/desku/ui/display/Text.java b/src/main/java/com/osiris/desku/ui/display/Text.java
@@ -20,21 +20,21 @@ public Text(String s) {
         super(s, String.class, "txt");
         setValue(s);
         // Attach Java event listeners
-        UI win = UI.get();
+        UI ui = UI.get();
         Runnable registration = () -> {
             _onValueAppended.addAction((childString) -> {
-                win.executeJavaScriptSafely(win.jsGetComp("comp", id) +
+                ui.executeJavaScriptSafely(ui.jsGetComp("comp", id) +
                                 "var childString = document.createTextNode(`" + childString + "`);\n" +
                                 "comp.appendChild(childString);\n",
                         "internal", 0);
             });
             _onEmptyValue.addAction((_void) -> {
-                win.executeJavaScriptSafely(win.jsGetComp("comp", id) +
+                ui.executeJavaScriptSafely(ui.jsGetComp("comp", id) +
                                 "comp.textContent = '';\n", // remove all text nodes
                         "internal", 0);
             });
         };
-        win.runIfReadyOrLater(registration);
+        ui.runIfReadyOrLater(registration);
     }
 
     public Text setValue(String v) {

diff --git a/src/main/java/com/osiris/desku/ui/input/TextArea.java b/src/main/java/com/osiris/desku/ui/input/TextArea.java
@@ -25,18 +25,20 @@ public TextArea(String label, String defaultValue) {
         this(new Text(label).sizeS(), defaultValue);
     }
 
-    public TextArea(Text label, String defaultValue) { // TODO defaultValue is not visible in UI
+    public TextArea(Text label, String defaultValue) {
         super(defaultValue, String.class);
         addClass("input-group");
         this.label = label;
         this.defaultValue = defaultValue;
         this.input = new Input<>("textarea", defaultValue, String.class, "textarea");
         add(this.label, this.input);
         childVertical();
+        setValue(defaultValue);
     }
 
     public TextArea setValue(String v) {
         input.setValue(v);
+        input.executeJS("comp.textContent = `"+ValueChangeEvent.escapeString(v)+"`;\n");
         return this;
     }