Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11512: notification - Unexpected behavior when using Notification with CloseAfterTime #1010

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

This PR is to guarantee the autoclose of Notification works and respects the waiting time configured by the developer

What was happening

  • When the notification was configured with CloseAfterTime, and the user interrupted this logic via API or interaction, the timeout triggering the close was not clean. This was causing an issue once the notification was triggered again. At that moment the old timeout could continue and close the notification without respecting the CloseAfterTime time that should be refreshed in every opening.

What was done

  • add logic to clean Notification autoclose timeout every time the user closes the notification.

Test Steps

  1. Go to Sample
  2. Config Notification to CloseAfterTime 5000
  3. Trigger and Close the notification repeatedly
  4. After a few cycles trigger it and wait for the auto close
  5. The notification should close after the intended timeframe.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the bug Something isn't working label Jan 14, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner January 14, 2025 18:38
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 98568cc into dev Jan 15, 2025
15 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11512 branch January 15, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants