Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4633 - [OSUI] - Issue applying favicon icon in PWA application #851

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

This PR is for fixing the favicon API on PWA applications

What was happening

  • The API AddFavicon was not working on PWA since the selector that checks if the favicon exists was editing link rel="apple-touch-icon" instead of creating the link for the favicon.

What was done

  • change Favicon selector to be more strict.

Test Steps

  1. Generate a PWA Application that has a favicon
  2. Check if the favicon is there when running the layout

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 9141a14 into dev Nov 3, 2023
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-4633 branch November 3, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants