Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4649: Fix issue on arrow navigation when a TabHeader is disabled #867

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

bmarcelino-fe
Copy link
Contributor

This PR is for fix an issue on arrow navigation when the tabs header is disabled.

What was happening

  • When Tabs pattern contains disabled tabs header inside, it's possible to reach the element disabled using the arrows left/right
    IssueTabsDisable

What was done

  • Add a new list of enabled items
  • Review the _handleKeypressEvent method to use the new list of enabled elements
  • Review each key behavior to lock the navigation for disabled items
    2023-12-04 17 44 34

Test Steps

  1. Open Sample Page
  2. Navigate to tabs using Tab key
  3. On tabs header, use the arrows to navigate between elements
  4. Expected: The disabled tabs header can't be reached or selected.

Screenshots

(prefer animated gif)

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

…f enable elements when Add/Remove header occurs
…update of enable elements when Add/Remove header occurs"

This reverts commit 84b661a.
…f enable elements when Add/Remove header occurs
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarcelino-fe bmarcelino-fe merged commit 90d1b6a into dev Dec 6, 2023
12 checks passed
@bmarcelino-fe bmarcelino-fe deleted the ROU-4649 branch December 6, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants