-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROU-4664: Prevent dom move when inside popup #870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenOsodrac
requested review from
gnbm,
joselrio,
bmarcelino-fe,
rugoncalves,
JoaoFerreira-FrontEnd and
OS-giulianasilva
as code owners
December 6, 2023 14:52
OS-giulianasilva
previously approved these changes
Dec 6, 2023
OS-giulianasilva
previously approved these changes
Dec 6, 2023
joselrio
requested changes
Dec 7, 2023
src/scripts/OSFramework/OSUI/Pattern/Dropdown/ServerSide/DropdownServerSide.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
OS-giulianasilva
approved these changes
Dec 7, 2023
joselrio
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue happens only in ODC, as the new version of react-dom adds all events on the ReactContainer, instead of adding it on every widget. This causes an issue with widgets inside the DropdownServerSide, when placed inside the Popup. As the Popup is placed outside the reactContainer, together with the MoveElement we are doing on the Dropdown, it causes all widgets inside to loose the attached listeners.
This approach was followed, as no other tested solved the issue. Removing the MoveElement and changing the overall position to fixed, would cause issues inside other patterns, like the Sidebar This was the most safe and reliable solution found.
Checklist