Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-4721: fixed dropdown inside popup #893

Merged
merged 3 commits into from
Jan 17, 2024
Merged

ROU-4721: fixed dropdown inside popup #893

merged 3 commits into from
Jan 17, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Jan 16, 2024 •
edited
Loading

This PR is for fixing the DropdownServerSide when is placed inside the Popup, on certain window sizes.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@BenOsodrac BenOsodrac requested a review from a team as a code owner January 16, 2024 17:29
joselrio
joselrio previously approved these changes Jan 16, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BenOsodrac BenOsodrac merged commit baf9a2b into dev Jan 17, 2024
10 of 13 checks passed
@BenOsodrac BenOsodrac deleted the ROU-4721 branch January 17, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd approved these changes

@joselrio joselrio joselrio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenOsodrac @joselrio @JoaoFerreira-FrontEnd