Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11287: [OSUI] - Defect with Skip to Content link #999

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

This PR is for fixing an accessibility issue on the skipToContent link.

What was happening

  • A tabIndex= "0" was added to the main content but removed, and that should only happen after the focus changes to another element.

What was done

  • remove tabIndex on a target blur listener;
  • add blur function to remove tab index and listener;

Test Steps

  1. Reach skip to content link using TAB navigation and trigger it
  2. Check the main-content element on the dom has tabindex=”0”
  3. Use tab or mouse to navigate to other element
  4. Check the main-content element on the dom doesn’t have tabindex anymore
  5. Check the blur listeners of main-content element, it should have been removed

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

- add blur function to remove tabindex and listener;
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner October 18, 2024 10:59
Copy link

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 13d3585 into dev Oct 18, 2024
9 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11287 branch October 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants