EMI Compact #1186
Open
EMI Compact #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crafting, smelting and I believe all other stuff that this adds EMI compatibility for is based in SophisticatedCore and as such the compatibility should go there as well if possible or a common a layer should be there if there needs to be mod SB / SS specific implementation in the mods (like if there absolutely needs to be a container type check instead of instance check) |
|
There is something wrong with client recipe filler during my playing. Maybe I have to implement the logic by myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods in
emi.SBPEmiPluginhave the same names with methods injei.SBPPlugin, for better maintainability.