Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitter API and make test cases work #289

Merged
merged 27 commits into from
Jul 9, 2024
Merged

Fitter API and make test cases work #289

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c3abd93
Add Fitter API and APFitter implementation
May 13, 2024
a73dcb4
Delete base.py and use Fitter API in Model class implementation
May 14, 2024
87a6e18
Regular floats for Features _bounds_dtype to exactly match test
May 14, 2024
a5e370d
Fixes based on test cases
May 14, 2024
9ded572
Remove obsolete helpers.calculate_compounds, more formatting
May 14, 2024
c1a2665
Remove mentions of PAHFITBase
May 14, 2024
96757a6
Clarify Fitter API operation description
May 14, 2024
a9311cc
Array vs scalar arguments to determine fitted/fixed in Fitter
May 17, 2024
02cd40b
Remove clear() from Fitter and APFitter
May 17, 2024
45d1497
Rename register_* to add_feature_*, clean up APFitter var names
May 17, 2024
add53ab
Model and geometry keywords for add_feature_attenuation/absorption
May 20, 2024
7aed851
Replace xz, yz by lam, flux
May 20, 2024
edcbbf6
Docstring and formatting fixes
May 20, 2024
4057012
Add TODO in guess to replace fwhm guessing by sigma_v
May 21, 2024
8f4d2bc
Work with self.fitter directly instead fitter argument/return
May 21, 2024
ac2146f
Remove Fitter.components(), instead keep 'enabled' list in Model
May 21, 2024
2942c08
Don't copy when applying feature mask in tabulate
Jun 25, 2024
30b0c2e
Better documentation and variable names for _set_up_fitter
Jun 25, 2024
e241077
Replace wavelengths named w by lam
Jun 25, 2024
040798d
Fix instrument and redshift being swapped in Features metadata
Jun 25, 2024
032ed4b
Fix style issue
Jun 25, 2024
f53c8db
Put fitter modules in pahfit.fitters. Rename apfitter to ap_fitter.
Jun 25, 2024
a990b47
Fix astropy contribution guide link
drvdputt Jul 3, 2024
2dc3c80
Replace links to PAHFIT classic
drvdputt Jul 3, 2024
5d22489
Rephrase comment explaining redshift adjustment of fwhm
drvdputt Jul 3, 2024
da9ed24
Replace more cases of "wav" by "lam", fix redshift bug in plot
drvdputt Jul 8, 2024
4e16008
Use "is np.ma.masked" when interpreting fwhm column
drvdputt Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ contributors page on Github
Reference API
=============

Base class for PAHFIT

.. automodapi:: pahfit.base

Component models not provided by astropy.models.

.. automodapi:: pahfit.component_models
Loading
Loading