Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fractions #42

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Updated fractions #42

merged 3 commits into from
Apr 11, 2024

Conversation

alexmaragko
Copy link
Contributor

  • Replaced ionization fraction with charge fractions.
  • Replaced large fraction with size fractions.
  • Computed nc and added to fits format as an extension.
  • Added the ionized-over-neutral PAH fraction extension.
  • Updated plots with the above.
  • Updated tests.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.29730% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.98%. Comparing base (486f85e) to head (939a542).

Files Patch % Lines
pypahdb/decomposer_base.py 94.91% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   90.88%   91.98%   +1.09%     
==========================================
  Files           4        4              
  Lines         450      524      +74     
==========================================
+ Hits          409      482      +73     
- Misses         41       42       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PAHdb PAHdb merged commit ca87c42 into PAHdb:master Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants