Updates to support PALEOaqchem generic chemistry #115
Merged
+151
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New VariableFunction VF_StateTotal to distinguish state variables associated with Total variables from VariableFunction VF_State which is now only used for state variables associated with Constraint variables. See PALEOmodel SolverView documentation for rationale. - Update StandardAttributes list (add :totalnames, :rate_processname, :rate_species, :rate_stoichiometry, :diffusivity, :charge, remove :totalname) Add 'standard_attribute_type' function to simplify netcdf output/input. - ReactionReservoir remove 'stateexplicit' parameter. Use new PALEOaqchem ReactionConstraintReservoir, ReactionImplicitReservoir instead for DAE constraint on implicit variables. - Remove ReactionReservoirConc, ReactionReservoirConcTotal names. This is a fix for possible name clash with work-in-progress atm chem configs, can still use ReactionReservoir, ReactionReservoirTotal with parameter 'state_conc = true'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New VariableFunction VF_StateTotal to distinguish state variables associated with Total variables from state variables associated with Constraint variables (which continue to use VariableFunction VF_State). See PALEOmodel SolverView documentation for rationale.
Update StandardAttributes list (add :totalnames, :rate_processname, :rate_species, :rate_stoichiometry, :diffusivity, :charge, remove :totalname). Add 'standard_attribute_type' function to simplify netcdf output/input.
ReactionReservoir remove 'stateexplicit' parameter. Use new PALEOaqchem ReactionConstraintReservoir, ReactionImplicitReservoir instead.
Remove ReactionReservoirConc, ReactionReservoirConcTotal names. This is a fix for possible name clash with work-in-progress atm chem configs, can still use ReactionReservoir, ReactionReservoirTotal with parameter 'state_conc = true'.