Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress to support parameter etc local sensitivity studies #64

Closed
wants to merge 1 commit into from

Conversation

sjdaines
Copy link
Member

Will also need changes to PALEOmodel

This will require three groups of changes:

  • Reaction parameters

    • add field to ReactionBase to hold a NamedTuple of values (probably Dual numbers for AD) that override parametes
    • changes to dispatch to merge in these parameters during dispatch
    • some changes to PALEOmodel to aggregate these into a Vector and calculate Jacobians etc
  • Constant Variables (currently initialised via attributes)

    • provide some way of defining which constant variables are considered modifiable for sensitivity studies
    • a method to change values in all data array sets in modeldata (when AD hence additional data arrays in use)
  • Initial values for state variables

    • probably needs changes to PALEOmodel to make it convenient to change these

Will also need changes to PALEOmodel

This will require three groups of changes:

- Reaction parameters
  - add field to ReactionBase to hold a NamedTuple of values (probably Dual numbers for AD) that override parametes
  - changes to dispatch to merge in these parameters during dispatch
  - some changes to PALEOmodel to aggregate these into a Vector and calculate Jacobians etc

- Constant Variables (currently initialised via attributes)
  - provide some way of defining which constant variables are considered modifiable for sensitivity studies
  - a method to change values in all data array sets in modeldata (when AD hence additional data arrays in use)

- Initial values for state variables
  - probably needs changes to PALEOmodel to make it convenient to change these
@sjdaines sjdaines marked this pull request as draft November 13, 2022 17:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #64 (14a7866) into main (05bc6a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   56.82%   56.82%           
=======================================
  Files          38       38           
  Lines        3833     3833           
=======================================
  Hits         2178     2178           
  Misses       1655     1655           
Impacted Files Coverage Δ
src/Reaction.jl 82.83% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sjdaines
Copy link
Member Author

sjdaines commented May 5, 2024

Now mostly implemented, see #123

@sjdaines sjdaines closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants