Rationalize use of Domains and fluxes in ocean and oceanfloor reactions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal is to make configuration of 0D ocean consistent with the configurations used for multi-box oceans, and remove some earlier bodges. NB: these are breaking changes - 0D COPSE ocean configs now explicitly use a ReactionOceanNoTransport with one cell. Previous bodge to set up grids removed from ReactionOceanBurialCOPSE - oceanfloor ReactionCarbBurialAlk now writes fluxes to `fluxOceanfloor.soluteflux_DIC` and optionally `fluxOceanfloor.soluteflux_Ca`, instead of directly to ocean state variable _sms variables. This makes this reaction consistent with the other oceanfloor reaction ReactionSeafloorWeathering and ReactionSrOceanfloor. Configurations will need updating to correctly transfer these fluxes to ocean / atmocean state variable derivatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to make configuration of 0D ocean consistent with the configurations used for multi-box oceans, and remove some earlier bodges.
NB: these are breaking changes
0D COPSE ocean configs now explicitly use a
ReactionOceanNoTransportwith one cell to configure the ocean, oceansurface, oceanfloor, fluxOceanfloor and fluxOceanBurial domains with a one-cell grid. Previous bodge to set up grids removed fromReactionOceanBurialCOPSE.oceanfloor
ReactionCarbBurialAlknow writes fluxes tofluxOceanfloor.soluteflux_DICand optionallyfluxOceanfloor.soluteflux_Ca, instead of directly to ocean state variable_smsvariables. This makes this reaction consistent with the other oceanfloor reactionsReactionSeafloorWeatheringandReactionSrOceanfloor. Configurations will need updating to correctly transfer these fluxes to ocean / atmocean state variable derivatives.