Skip to content

Commit

Permalink
sync with PALEOaqchem v0.3.16 updates
Browse files Browse the repository at this point in the history
  • Loading branch information
sjdaines committed Dec 1, 2024
1 parent 26bfa45 commit 394cc5a
Show file tree
Hide file tree
Showing 13 changed files with 18 additions and 17 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Documenter = "1.0"
Infiltrator = "1.0"
LineSearches = "7.0"
NLsolve = "4.5.1"
PALEOaqchem = "0.3.15"
PALEOaqchem = "0.3.16"
PALEOboxes = "0.21.33"
PALEOmodel = "0.15.8"
Pkg = "1.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ sediment_Corg_O2NNMnFeSP:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
2 changes: 1 addition & 1 deletion examples/CONPSFeMn/PALEO_examples_sediment_NNFeMn_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ sediment_Corg_O2NNMnFeS:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
2 changes: 1 addition & 1 deletion examples/FOAM/PALEO_examples_sediment_FOAM_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ sediment_FOAM:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ sediment_Corg_Stest:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
4 changes: 2 additions & 2 deletions examples/boudreau1996/PALEO_examples_sediment_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ sediment_Corg_O2:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down Expand Up @@ -421,7 +421,7 @@ sediment_Corg_O2_carb:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ sediment_Corg_O2_Fe:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down Expand Up @@ -524,7 +524,7 @@ sediment_Corg_O2_Fe_pyr_carb:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ sediment_abiotic_O2:
trspt_sms_ext: _trspt_sms

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
2 changes: 1 addition & 1 deletion examples/transport_tests/PALEO_transport_RCmultiG_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ sediment_abiotic_O2:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
2 changes: 1 addition & 1 deletion examples/transport_tests/PALEO_transport_mudCorg_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ sediment_abiotic_O2:
trspt_sms_ext: _trspt_sms

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
2 changes: 1 addition & 1 deletion examples/transport_tests/PALEO_transport_mud_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ sediment_abiotic_O2:
trspt_sms_ext: _trspt_sms

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
2 changes: 1 addition & 1 deletion examples/transport_tests/PALEO_transport_sediment_cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ sediment_abiotic_O2:
class: ReactionSedimentTransportSolid

molecular_diffusivity:
class: ReactionAqMolecularDiffusion
class: ReactionAqMolecularDiffusivity

transportsedsolute:
class: ReactionSedimentTransportSolute
Expand Down
7 changes: 4 additions & 3 deletions src/sediment/SedimentTransport.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module SedimentTransport
import PALEOboxes as PB
using PALEOboxes.DocStrings
import PALEOsediment
import PALEOaqchem

import LinearAlgebra
import SparseArrays
Expand Down Expand Up @@ -324,7 +323,7 @@ Bioturbation (`diff_bioturb [m^2 yr-1]`) and bioirrigation (`alpha_bioirrig [yr-
on the sediment grid by eg [`PALEOsediment.Sediment.SedimentBioRates.ReactionSedimentBioRates`](@ref).
Molecular diffusivity should be supplied for each species by Variables `<speciesname>_moldiff [cm^2 s-1]` eg as calculated by
`PALEOaqchem.MolecularDiffusion.ReactionAqMolecularDiffusion` or set to a constant using `PALEOboxes.ReactionConst`.
`PALEOaqchem.MolecularDiffusion.ReactionAqMolecularDiffusivity` or set to a constant using `PALEOboxes.ReactionConst`.
## Boundary conditions
Expand Down Expand Up @@ -832,14 +831,16 @@ end
"""
SoluteCombinedDiffusivity(moldiff::Vector, Dfac::Vector, bioturb::Vector) -> scd
calculate `scd[i]` `cm^2 s-1`, tortuoisity-corrected solute diffusivity combined with bioturbation
Calculate `scd[i]` `m^2 yr-1`: tortuoisity-corrected solute diffusivity combined with bioturbation
for Vector index `i`.
"""
struct SoluteCombinedDiffusivity{M, D, B}
moldiff::M
Dfac::D
bioturb::B
end

# implementation of scd[i]
function Base.getindex(scd::SoluteCombinedDiffusivity, i)
# m^2 yr-1 = cm^2 s-1 * s yr-1 * (cm m-1)^2
cd = scd.moldiff[i] * PB.Constants.k_secpyr*1e-4*scd.Dfac[i] + scd.bioturb[i]
Expand Down

0 comments on commit 394cc5a

Please sign in to comment.