Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENSO portrait plot #1245

Merged
merged 12 commits into from
Feb 6, 2025
Merged

ENSO portrait plot #1245

merged 12 commits into from
Feb 6, 2025

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Feb 6, 2025

No description provided.

@lee1043 lee1043 self-assigned this Feb 6, 2025
@lee1043 lee1043 linked an issue Feb 6, 2025 that may be closed by this pull request
@lee1043 lee1043 marked this pull request as ready for review February 6, 2025 20:36
@lee1043
Copy link
Contributor Author

lee1043 commented Feb 6, 2025

@acordonez could you please help checking if the new notebook in this PR (pcmdi_metrics/enso/lib/summary_plot_lib/enso_portrait_plot.ipynb) working okay on your end? It includes using some new functions newly added via this PR, so will need a manual installation of the code in the PR before running the notebook.

@lee1043 lee1043 requested a review from acordonez February 6, 2025 21:05
@lee1043 lee1043 added this to the 3.8.3 milestone Feb 6, 2025
@lee1043
Copy link
Contributor Author

lee1043 commented Feb 6, 2025

@zhangshixuan1987 you are more than welcome to take a look the notebook and make suggestions.

@acordonez
Copy link
Collaborator

@lee1043 I ran pcmdi_metrics/enso/lib/summary_plot_lib/enso_portrait_plot.ipynb and did not encounter any errors.

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 6, 2025

@acordonez thank you for checking it!

@lee1043 lee1043 merged commit 27e4ca4 into main Feb 6, 2025
4 checks passed
@lee1043 lee1043 deleted the 1236_enso_portrait branch February 6, 2025 23:06
@zhangshixuan1987
Copy link
Collaborator

@lee1043 : Hi Jiwoo, The metrics look great to me. I saw that this has been merged into the current code branch, and let me try to also implement it in the e3sm-pmp-zppy workflow, and I will update you on the sample figures.

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 7, 2025

@zhangshixuan1987 thank you! The content of the notebook also can be found here: http://pcmdi.github.io/pcmdi_metrics/examples/enso_portrait_plot.html. Until releasing a new version, please sync your PMP main branch to the latest, and do "pip install ." to install it in your local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENSO portrait plot notebook
3 participants