Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version checks #350

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix version checks #350

merged 1 commit into from
Dec 20, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 20, 2024

Add function for parsing version numbers. Update checks.

Fixes #349.

Add function for parsing version numbers. Update checks.

Fixes PEtab-dev#349.
@dweindl dweindl requested a review from a team as a code owner December 20, 2024 10:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.64%. Comparing base (9f11e73) to head (aee4707).

Files with missing lines Patch % Lines
petab/versions.py 75.00% 4 Missing and 1 partial ⚠️
petab/v1/problem.py 40.00% 0 Missing and 3 partials ⚠️
petab/v2/problem.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #350      +/-   ##
===========================================
+ Coverage    74.61%   74.64%   +0.02%     
===========================================
  Files           56       56              
  Lines         5571     5589      +18     
  Branches       978      980       +2     
===========================================
+ Hits          4157     4172      +15     
- Misses        1041     1043       +2     
- Partials       373      374       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 6a9ecd0 into PEtab-dev:develop Dec 20, 2024
7 checks passed
@dweindl dweindl deleted the fix_version_checks branch December 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants