Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post--model-selection analysis methods #125

Merged
merged 30 commits into from
Jan 6, 2025
Merged

Add post--model-selection analysis methods #125

merged 30 commits into from
Jan 6, 2025

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Dec 2, 2024 •
edited
Loading

  • notebook with examples
    • briefly explain some analysis methods in an RTD page. A notebook would not provide much more information.
  • rewrite plot code to use these methods
  • check RTD

@dilpath dilpath changed the base branch from main to develop December 2, 2024 20:08
@dilpath dilpath requested a review from dweindl December 14, 2024 20:03
dweindl
dweindl approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

Consider clearing notebook outputs.

doc/analysis.rst Outdated Show resolved Hide resolved
doc/analysis.rst Show resolved Hide resolved
petab_select/analyze.py Outdated Show resolved Hide resolved
@dilpath
Copy link
Member Author

dilpath commented Jan 6, 2025

Consider clearing notebook outputs.

Currently there is a chain of 5 PRs to be merged, notebooks are cleared as suggested in the 5th PR (#134) 😀

@dweindl
Copy link
Member

dweindl commented Jan 6, 2025

Consider clearing notebook outputs.

Currently there is a chain of 5 PRs to be merged, notebooks are cleared as suggested in the 5th PR (#134) 😀

By then, there will be 5 more versions of all plots in the git history 🚯

@dilpath dilpath merged commit ddb289f into develop Jan 6, 2025
0 of 3 checks passed
@dilpath dilpath deleted the analyze branch January 6, 2025 16:23
@dilpath dilpath restored the analyze branch January 6, 2025 16:23
@dilpath dilpath deleted the analyze branch January 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilpath @dweindl