Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standard/schema for Problem #132

Merged
merged 96 commits into from
Jan 6, 2025
Merged

Create standard/schema for Problem #132

merged 96 commits into from
Jan 6, 2025

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Jan 2, 2025

I decided against doing something similar for ModelSpace, because it's current TSV format is not normalized. Maybe in PEtab Select v2, "frictionless" can be used.

Breaking change: in model space files, the column header petab_yaml is now model_subspace_petab_yaml. This is to reduce a possible source of confusion: this PEtab problem is not a model in the model subspace.

@dilpath dilpath requested a review from dweindl January 2, 2025 22:52
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test_cases/0009/README.md Outdated Show resolved Hide resolved
@dilpath dilpath changed the base branch from mkstd_models to develop January 6, 2025 15:32
@dilpath dilpath merged commit d4fce46 into develop Jan 6, 2025
0 of 3 checks passed
@dilpath dilpath deleted the mkstd_model_space branch January 6, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants