Squiz/ScopeKeywordSpacing: add additional tests #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done in a way to maintain the error line numbers for the rest of the file.
... as otherwise the test methods would be _unintentional_ parse errors. Includes making the method names unique.
This commit adds a few of tests for syntaxes in which the target keywords could be used, which were so far not covered by tests: * Tests with the `static` modifier keyword being used for closures. * Tests with visibility keyword applied to class constants.
Bow out earlier when the sniff won't be able to action anything anyway (live coding/parse errors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Squiz/ScopeKeywordSpacing: move parse error test to separate file
Done in a way to maintain the error line numbers for the rest of the file.
Squiz/ScopeKeywordSpacing: move some method tests into a class
... as otherwise the test methods would be unintentional parse errors.
Includes making the method names unique.
Squiz/ScopeKeywordSpacing: add additional tests
This commit adds a few of tests for syntaxes in which the target keywords could be used, which were so far not covered by tests:
staticmodifier keyword being used for closures.Squiz/ScopeKeywordSpacing: minor efficiency tweak
Bow out earlier when the sniff won't be able to action anything anyway (live coding/parse errors).
Suggested changelog entry
Squiz.WhiteSpace.ScopeKeywordSpacing: minor efficiency improvement
Related issues/external references
Follow up on #604 (review)