Travis: add a check against false positives #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/travis-check-self-exclude
branch
from
be7ac04 to
f1974db
Compare
This adds an additional check to the Travis build. PR 2 added `exclude`s to the ruleset to prevent false positives being generated when the ruleset would be run against the code of the polyfill itself. As the polyfill may, of course, be updated over time, we need to ensure that these excludes are still sufficient. This adds a `dev` dependency on the actual polyfill and a check to Travis to make sure that if the ruleset is run over the polyfill code, no errors are thrown. **Note**: this check may start failing without notice because of changes in the polyfill, but that's exactly what this check is guarding against and will prevent us from releasing a version which doesn't have the right excludes in place. In addition to this, an automatic weekly/monthly Travis run on `master` should be turned on to make sure this check is run on a semi-regular basis. _For now, I've turned an automatic monthly check on_ Additionally: * I've also merged the duplicate `cache` key in the Travis script. * And the integration tests now run against an open-ended `testVersion`.
jrfnl
force-pushed
the
feature/travis-check-self-exclude
branch
from
f1974db to
a262ff4
Compare
wimg
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional check to the Travis build.
PR #2 added
excludes to the ruleset to prevent false positives being generated when the ruleset would be run against the code of the polyfill itself.As the polyfill may, of course, be updated over time, we need to ensure that these excludes are still sufficient.
This adds a
devdependency on the actual polyfill and a check to Travis to make sure that if the ruleset is run over the polyfill code, no errors are thrown.Note: this check may start failing without notice because of changes in the polyfill, but that's exactly what this check is guarding against and will prevent us from releasing a version which doesn't have the right excludes in place.
In addition to this, an automatic weekly/monthly Travis run on
mastershould be turned on to make sure this check is run on a semi-regular basis.For now, I've turned an automatic monthly check on
Additionally:
cachekey in the Travis script.testVersion.