Composer: fix the version retrieved for the PHP 7.2 polyfill & fix CI #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony dropped support for PHP < 7.2 in the Symfony polyfills 1.31 series. This means that the `1.31` version of the PHP 7.2 polyfill no longer contains any code/polyfills as the minimum supported PHP version has become PHP 72, so the maximum allowed version of the `symfony/polyfill-php72` package - for our purposes (testing) - needs to be fixed to v `1.30`. This is a similar change as was previously applied for the older polyfills via PR 21. As for the Symfony polyfills for PHP 7.3 and higher: these now have a PHP 7.2 minimum supported PHP version, so CI needs to be adjusted to allow for PHP 7.2 syntaxes being used in those packages. It also means we need a separate build to safeguard PHP 7.1 compatibility at v 1.30 of the Polyfills (before the version drop of PHP < 7.2). This is a similar change as was previously applied after the Symfony PHP < 7.1 version drop via PR 24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony dropped support for PHP < 7.2 in the Symfony polyfills 1.31 series. This means that the
1.31version of the PHP 7.2 polyfill no longer contains any code/polyfills as the minimum supported PHP version has become PHP 72, so the maximum allowed version of thesymfony/polyfill-php72package - for our purposes (testing) - needs to be fixed to v1.30. This is a similar change as was previously applied for the older polyfills via PR #21.As for the Symfony polyfills for PHP 7.3 and higher: these now have a PHP 7.2 minimum supported PHP version, so CI needs to be adjusted to allow for PHP 7.2 syntaxes being used in those packages. It also means we need a separate build to safeguard PHP 7.1 compatibility at v 1.30 of the Polyfills (before the version drop of PHP < 7.2). This is a similar change as was previously applied after the Symfony PHP < 7.1 version drop via PR #24.