Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for microsoft authenticator #80

Closed
wants to merge 1 commit into from
Closed

Support for microsoft authenticator #80

wants to merge 1 commit into from

Conversation

adars47
Copy link

@adars47 adars47 commented Jul 31, 2020

Microsoft authenticator needs that extra parameter to get the app name correct.

Microsoft authenticator needs that extra parameter to get the app name correct.
@MarkMaldaba
Copy link

Not sure why you are calling urlencode() inside urlencode(). That will result in double-escaping!

Also, for the record, this doesn't only affect Microsoft Authenticator - other apps are also affected (e.g. FreeOTP).

Note that PR #76 contains an alternative solution to the same problem, though it also suffers from the double-escaping issue.

@MarkMaldaba MarkMaldaba mentioned this pull request Mar 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants