-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writer EPub3 : Added support #2724
Conversation
…composer.lock (in support of PR PHPOffice#2722 : Autoload)
@Progi1984 can you please review this PR? |
@Sambit003 Could you implement basic Text and Image Elements ? No need styles. I just want that Epub generated contains image and text. After that, I can review. |
Sure. Then i'm removing the part of the style. Already the text and image element part is there. Again I will give it a thorough check. |
Let the basic style you made. It's perfect in a first time. |
Yeah okay |
@Progi1984 I've added the Text and Image element implementation. I'm working on unit tests and conventions. Will push those soon. |
@Progi1984 Hi, I've implemented the features and Unit tests you've asked. Can you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedbacks, but it's a good job.
Could you send me a sample generated file ? (May be the samples/Sample_01_SimpleText.php
)
I want to check it with epubcheck
(https://www.w3.org/publishing/epubcheck/).
Don't forget to update the changelog (https://github.com/PHPOffice/PHPWord/blob/master/docs/changes/1.x/1.4.0.md).
Oh, I've missed that part. I'll make the necessary changes needed. And will upload the epub file here once it's ready |
Need that :) |
Yes. Was unavailable due to some personal reasons. I'm working on that part now. |
I can't upload the generated epub file. It's not supported But, i've checked with the tool you've mentioned and changed the required codebase according to that with unit tests. |
@Progi1984 Can you please review now? |
It's nearly perfect job. My last : update the changelog. And it will be ok for me. |
Changelog is updated |
@Sambit003 I will merge it on Monday. I'm not in front of my computer. 💕 For all your work. |
@Progi1984 Thank you for merging❤️. It was really nice to work with you and also learnt something new here. And can you please tell me that when I'll receive that bounty claim? Like this one is my first so. |
@Sambit003 It's done, NOW 😛 🎉 Congratulations for my first bounty and your first bounty 🎉 |
Thanks bro🤪❤️❤️. And also i would love to work on the style part. |
Description
Implemented ePub3 writer support
Fixes #55
/claim #55
Checklist: