Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please check the commit #115

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Please check the commit #115

merged 3 commits into from
Jan 9, 2025

Conversation

deeptijk
Copy link
Collaborator

@deeptijk deeptijk commented Nov 11, 2024

User description

@ypriverol I have made changes to TMT channels....added all the parent labels to channels


PR Type

enhancement


Description

  • Updated the pride_cv.obo file to enhance the TMT channel definitions by adding specific parent labels for different TMT plex labeling kits.
  • Introduced new terms for TMT6PLEX, TMT10PLEX, TMT16PLEX, and TMT18PLEX, specifying the number of channels each kit has.
  • Corrected the parent labels for existing TMT channels to reflect the appropriate plex labeling kits.
  • Updated metadata including the data version and the person who saved the file.

Changes walkthrough 📝

Relevant files
Enhancement
pride_cv.obo
Enhance TMT channel definitions with specific labeling kits

pride_cv.obo

  • Updated the data version and saved-by metadata.
  • Added new parent labels for TMT channels, specifying different plex
    labeling kits.
  • Introduced new terms for TMT labeling kits with specific channel
    counts.
  • Corrected and updated existing TMT channel definitions with
    appropriate parent labels.
  • +86/-30 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Inconsistent Definition
    The term TMT16PLEX appears twice with different IDs (PRIDE:0000668 and PRIDE:0000669) but has inconsistent definitions - one states "16 channels" while the other states "18 channels"

    Incorrect Parent Label
    Some TMT channels are assigned to multiple parent labels that appear contradictory. For example, TMT126 is labeled as belonging to 6-plex, 10-plex, 16-plex and 18-plex simultaneously

    Copy link

    qodo-merge-pro bot commented Nov 11, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    ✅ Fix inconsistent naming and definition for TMT labeling kit terms
    Suggestion Impact:The term TMT16PLEX was renamed to TMT18PLEX and the definition was corrected to match the 18 channels description.

    code diff:

     id: PRIDE:0000669
    -name: TMT16PLEX
    -def: "TMT 18-plex labeling kit has 16 channels" [PRIDE:PRIDE]
    +name: TMT18PLEX
    +def: "TMT 18-plex labeling kit has 18 channels" [PRIDE:PRIDE]

    The term TMT16PLEX is used twice with different IDs (PRIDE:0000668 and
    PRIDE:0000669) but different definitions. The second instance should be renamed to
    TMT18PLEX to match its definition.

    pride_cv.obo [4056-4058]

     [Term]
     id: PRIDE:0000669
    -name: TMT16PLEX
    -def: "TMT 18-plex labeling kit has 16 channels" [PRIDE:PRIDE]
    +name: TMT18PLEX
    +def: "TMT 18-plex labeling kit has 18 channels" [PRIDE:PRIDE]
     is_a: PRIDE:0000515 ! TMT
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion identifies a critical inconsistency where the same name (TMT16PLEX) is used for two different terms with different IDs and definitions, which could cause serious confusion and errors in data annotation.

    9
    Possible bug
    ✅ Correct inaccurate channel count in labeling kit definition
    Suggestion Impact:The suggestion corrected the name and definition of the TMT18PLEX labeling kit to accurately reflect that it has 18 channels instead of 16.

    code diff:

     id: PRIDE:0000669
    -name: TMT16PLEX
    -def: "TMT 18-plex labeling kit has 16 channels" [PRIDE:PRIDE]
    +name: TMT18PLEX
    +def: "TMT 18-plex labeling kit has 18 channels" [PRIDE:PRIDE]

    The definition for TMT18PLEX states "has 16 channels" which appears incorrect since
    an 18-plex kit should have 18 channels.

    pride_cv.obo [4056-4058]

     id: PRIDE:0000669
    -name: TMT16PLEX
    -def: "TMT 18-plex labeling kit has 16 channels" [PRIDE:PRIDE]
    +name: TMT18PLEX
    +def: "TMT 18-plex labeling kit has 18 channels" [PRIDE:PRIDE]
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion fixes a critical data accuracy issue where the definition incorrectly states "16 channels" for an 18-plex kit, which could lead to serious misunderstandings in experimental protocols.

    9

    💡 Need additional feedback ? start a PR chat

    @deeptijk
    Copy link
    Collaborator Author

    @ypriverol please check

    @ypriverol ypriverol merged commit 10f48f5 into master Jan 9, 2025
    2 checks passed
    @ypriverol ypriverol deleted the pride-ontology branch January 9, 2025 17:03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants