Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pride_cv.obo #119

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Update pride_cv.obo #119

merged 2 commits into from
Jan 16, 2025

Conversation

deeptijk
Copy link
Collaborator

@deeptijk deeptijk commented Jan 16, 2025

User description

added olink instruments


PR Type

Enhancement


Description

  • Updated definitions for Olink instruments to provide detailed descriptions.

  • Added new terms for Olink Explore and Olink Target platforms.

  • Adjusted hierarchy for Olink instrument models to reflect updated classifications.


Changes walkthrough 📝

Relevant files
Enhancement
pride_cv.obo
Updated Olink instrument definitions and hierarchy             

pride_cv.obo

  • Enhanced definitions for existing Olink instruments with detailed
    descriptions.
  • Added new terms: Olink Explore and Olink Target with specific
    definitions.
  • Updated hierarchy for Olink instruments to align with new
    classifications.
  • Renamed Olink Explore 3072 to Olink Explore 3072/384.
  • +19/-7   

    Need help?
  • Type /help how to ... in the comments thread for any question about Qodo Merge usage.
  • Check out the documentation for more information.
  • added olink instruments
    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Maintain consistent level of detail across related term definitions in the ontology

    Add specific panel information to the definition of Olink Target 96 to match the
    level of detail provided in other platform definitions.

    pride_cv.obo [3971-3972]

     name: Olink Target 96
    -def: "Olink Target 96 is a proteomics platform offering targeted analysis of 92 specific protein biomarkers per panel using proximity extension assay (PEA) technology." [PRIDE:PRIDE]
    +def: "Olink Target 96 is a proteomics platform offering targeted analysis of 92 specific protein biomarkers per panel using proximity extension assay (PEA) technology. Panels are designed for specific research areas including inflammation, oncology, and cardiovascular disease." [PRIDE:PRIDE]
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: Adding specific research areas would improve consistency with other platform definitions and provide valuable context for users, though it's important to verify the accuracy of the added information.

    6
    Include version history information in ontology term definitions when terms undergo significant name changes

    Add a version number or date to the definition of Olink Explore 3072/384 to indicate
    when this name change occurred, helping track the evolution of the platform.

    pride_cv.obo [3983-3984]

     name: Olink Explore 3072/384
    -def: "Olink Explore 3072 includes eight 384-plex panels for efficient, large-scale, disease- and process-focused studies." [PRIDE:PRIDE]
    +def: "Olink Explore 3072/384 (formerly Olink Explore 3072, renamed 2025) includes eight 384-plex panels for efficient, large-scale, disease- and process-focused studies." [PRIDE:PRIDE]
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: Adding version history information would improve traceability, but the suggested date (2025) appears speculative and could be misleading without verification.

    5

    version change and added the date
    @ypriverol ypriverol merged commit 08b6f6e into master Jan 16, 2025
    2 checks passed
    @ypriverol ypriverol deleted the deeptijk-patch-1 branch January 30, 2025 10:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants