fileNamesCheck #19
Open
fileNamesCheck #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakrabandla
reviewed
Dec 1, 2022
| if (!dataFile.getFileName().matches("[^-_.A-Za-z0-9]")){ | ||
| report.addMessage(new ValidationMessage(ValidationMessage.Type.WARNING, "POSIX compatible charset is NOT used in file name '" + actualFile.getName() + "'")); | ||
| if (dataFile.getFileName().matches("[^-_.A-Za-z0-9]")){ | ||
| report.addMessage(new ValidationMessage(ValidationMessage.Type.ERROR, "POSIX compatible charset is NOT used in file name '" + actualFile.getName() + "'")); |
There was a problem hiding this comment.
How does this error appear to user in submission tool? if the user is going to see text then it should be a more easily understandable sentence like only .-_ are allowed in a filename
There was a problem hiding this comment.
does this logic disallows user to submit files? or more changes are needed in submission tool code?
There was a problem hiding this comment.
yeah makes sense will change it.
|
It will deny user to proceed |
|
users should be forced to download new version of the tool |
|
yeah i havent update submission tool yet , waiting for experimental type addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.