Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small dev container #18

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Add small dev container #18

merged 7 commits into from
Aug 2, 2024

Conversation

Jakobeha
Copy link
Contributor

@Jakobeha Jakobeha commented Aug 2, 2024

See https://containers.dev/.

The devcontainer installs Debian, GNU-R (4.3.2 from source), Java (temurin 22), and Maven.

I'll also add documentation for how to set up the container, once I confirm it works. (done)

The devcontainer installs Debian, GNU-R (4.3.2 from source), and Java (temurin 22).
- Fix user, it has to be "vscode" or "root" unless we do more configuration
- Fix warnings in dockerfile
- Add tempfile to .gitignore
Updates also include:

- Add manual dependencies
- Reword "development notes"
I didn't fully update the design decisions, but changed the parts that were clearly outdated and added past experience (why we went with gRPC instead of ZeroMQ, why we chose to remove spotbugs, and why we removed the pre-push hook).

I also removed "currently" because it's redundant.

Lastly, I added a disclaimer since the design decisions will probably become outdated again.
It was downloading and installing `debuginfo`...

Since it's fixed, I can also remove `--disable-java` from GNU-R `./configure`.

Lastly, GNU-R needs `gfortran` at runtime.
@Jakobeha Jakobeha merged commit 86301e0 into main Aug 2, 2024
4 checks passed
@Jakobeha Jakobeha deleted the devcontainer branch August 2, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant