Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zig tests started failing #4050

Closed
max-sixty opened this issue Jan 4, 2024 · 3 comments
Closed

Zig tests started failing #4050

max-sixty opened this issue Jan 4, 2024 · 3 comments

Comments

@max-sixty
Copy link
Member

max-sixty commented Jan 4, 2024

What's up?

Any idea what caused this? I'm guessing it's an external change, maybe a zig version? I don't think anything has changed in that path, and the commit it failed on is

https://github.com/PRQL/prql/actions/runs/7412719385/job/20172886376

CC @vanillajonathan as our resident zig expert! :)

Disabled in #4051

@vanillajonathan
Copy link
Collaborator

Our CI uses the master branch of the Zig compiler. Commit ziglang/zig@c20ad51 changes a bunch of stuff which breaks it because it removes the linkSystemLibraryName function.

We use the goto-bus-stop/setup-zig GitHub Action which allows us to optionally specify the version of the Zig compiler to use. We could set it to version 0.11.0 for now.

@max-sixty
Copy link
Member Author

Yes, either pinning or adjusting for the newer zig sounds good!

@max-sixty
Copy link
Member Author

#4053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants