Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin Zig compiler version #4053

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

vanillajonathan
Copy link
Collaborator

Pin the Zig compiler version so the GitHub Action doesn't use the nightly version which has breaking changes.

This PR is related to issue #4050.

Pin the Zig compiler version so the GitHub Action doesn't use the nightly version which has breaking changes.
# working-directory: prqlc/bindings/clib/examples/minimal-zig
# run: make run test
# Pinned version — https://github.com/PRQL/prql/issues/4050
version: 0.11.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: When is this version supposed to be updated and by whom?
For example, the version of Elixir is specified in the same way, but it has not been updated in two years and is probably currently inappropriate.

otp: ["25.1.2"]
elixir: ["1.14.2"]

In my opinion it would be useful to be able to specify the latest release here. (This is hacky but I think we can use a script to set the latest version here)

Copy link
Collaborator Author

@vanillajonathan vanillajonathan Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I don't have any good answer.
I agree that it would be useful to be able to specify the latest release but the goto-bus-stop/setup-zig GitHub Action does not have any support for that.

I files a issue: goto-bus-stop/setup-zig#65

@vanillajonathan vanillajonathan merged commit 3e70591 into main Jan 5, 2024
37 checks passed
@vanillajonathan vanillajonathan deleted the vanillajonathan-patch-1 branch January 5, 2024 19:02
max-sixty pushed a commit to max-sixty/prql that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants