Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set owner on /usr/local/cargo/registry/ in Dev Container #5018

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

richb-hanover
Copy link
Contributor

This PR seems to address #5007 and #4974 which were related to reports of "not being able to build the Playground from a fresh installation of the Dev Container."

The answer seems to be to add sudo chown vscode /usr/local/cargo/registry/ to the postCreateCommand section of the Dev Container's JSON file.

There were SO MANY red herrings here...

  • Some operations gave an error trying to create a file in /usr/local/cargo/registry... (this was the hint toward the solution)

  • The initial report gave a mysterious ENOENT error out of the blue. That seemed to be caused by the failure to have installed wasm_pack. Using npm install wasm-pack caused that to go away.

  • cargo clean does indeed remove all the cached cargo files, but gives the "resource busy" on /workspaces/prql/target (which remains today)

I am content. I'm back to a steady state - I can build the Playground, Book, and Website from a dev container.

@richb-hanover richb-hanover changed the title Set owner on /usr/local/cargo/registry/ in Dev Container fix: Set owner on /usr/local/cargo/registry/ in Dev Container Nov 22, 2024
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems fine.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@eitsupi eitsupi changed the title fix: Set owner on /usr/local/cargo/registry/ in Dev Container build: Set owner on /usr/local/cargo/registry/ in Dev Container Jan 12, 2025
@max-sixty max-sixty merged commit 02deda5 into PRQL:main Jan 13, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants