Falcon handler: do not use deprecated resp.body
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a bit tricky to keep supporting Falcon 2.0 (which is 6 year old now), but assuming this is desirable, I changed `resp.body` to `resp.data`, since that already exists in 2.0, and we don't need to branch on version even more. `resp.body` has been deprecated throughout the 3.0 cycle (more than 3 years), and it will be removed in Falcon 4.0 (a stable release is planned soon).
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit tricky to keep supporting Falcon 2.0 (which is 6 year old now), but assuming this is desirable, I changed
resp.bodytoresp.data, since that already exists in 2.0, and we don't need to branch on version even more.resp.bodyhas been deprecated throughout the 3.0 cycle (more than 3 years), and it is removed in Falcon 4.0.Note that
test/falcon_test.pyseems to require at least Falcon 3.1, so I had to tweak them to verify 2.0 compatibility, but I didn't commit these changes. I did verify it still passed on 2.0 and Python 3.8.