Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-Docs-API-website UI | #8

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

karthik-nair-20
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Fixes #4

Did you add tests for your changes?
yes, I tested my changes

Snapshots/Videos:

399458603-57c1eff9-721b-4ea8-b145-e5ac88136fd1 399458574-a365637a-a1e0-4505-9d47-15e5ecc54bc4 399458590-c4f7ac21-8ac9-4966-8ec9-70cd33b45289 399458557-3fe2fb93-d5ba-4249-8957-d65685e0f6d2

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@karthik-nair-20
Copy link
Contributor Author

@palisadoes Sir, pls review and approve this PR

@palisadoes palisadoes merged commit 94de6eb into PalisadoesFoundation:develop Dec 31, 2024
6 checks passed
@karthik-nair-20 karthik-nair-20 deleted the websiteUi branch December 31, 2024 18:08
palisadoes added a commit that referenced this pull request Jan 13, 2025
* Added markdown files

* Updated markdown (#5)

* feat-UI: SM-Docs-API-website (#8)

* Update pull-request.yml

* Update pull-request.yml

* Update pull-request.yml

* Update pull-request.yml

* Update pull-request.yml

* Update pull-request.yml

* Update pull-request.yml

* Create .coderabbit.yaml

* Added linters to the pull request GitHub action workflows (#9)

* Added linters to the pull request GitHub action workflows

* Added linters to the pull request GitHub action workflows

* Fixed flake error

* Fixed black error

* Fixed black error v2

* Update check_docstrings.py

* Json (#10)

* JSON

* Test

* JSON

---------

Co-authored-by: Karthik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants