Admin - Remove Support for Private Organizations

[palisadoes]

Is your feature request related to a problem? Please describe.
We need to reduce and simplify some of the Talawa features.

The concept of private organizations is unlikely given that most organizations using Talawa will be non-profits where transparency will be important.

Therefore not just must the organizations be always public. They must also always be visible.

Describe the solution you'd like

Remove all support for private organizations in:

1. Sections of screens that contain references this feature
2. Any screens completely dedicated to this feature
3. All supporting code

Other:

1. All tests must be valid and pass
2. No other functionality must be affected.

Describe alternatives you've considered

• N/A

Approach to be followed (optional)

• See above

Additional context
Related issues include:

1. API - Remove Support for Private Organizations talawa-api#1604
2. Admin - Remove Support for Private Organizations #1327
3. Mobile - Remove Support for Private Organizations talawa#2287

Potential internship candidates

• Please read this if you are planning to apply for a Palisadoes Foundation internship Student Internship Programs talawa#359

[aialok]

I would love to work on this issue : )

[aialok]

• To be more clear about the given issue, I want to know in the above given picutres I need to remove isPublic functionality from the create Organisation modal ?

[palisadoes]

Please read the issue thoroughly

[palisadoes]

Please refer to this discussion before proceeding

• Convert Private Orgs to userRegistrationRequired Orgs talawa-api#1643 (comment)

[palisadoes]

FYI - The issue blocking this has been completed

• API - Remove Support for Private Organizations talawa-api#1604

[palisadoes]

Reopening because the introspection test in the previous PR failed.

@aialok please submit a follow up PR to fix this

[aialok]

Hey @palisadoes, I checked why the test failed and found the issue in the talawa-api repository, not talawa-admin. The problem is that the workflow is cloning the main branch of talawa-api, in which schema.graphql is not up to date as changes are done in develop branch, because of this isPublic is not updated with userRegistrationRequired in schema.graphql, causing the test to fail.

Here's the workflow file:

Here's the schema.graphql file:

And the failing GraphQL inspector:

[palisadoes]

@aialok How can we clone the develop branch instead?

[palisadoes]

I'll open an issue to fix this. The action needs to checkout the develop branch after cloning

[aialok]

I'll open an issue to fix this. The action needs to checkout the develop branch after cloning

Yeah or we can use directly git clone -b branch_name --single-branch https://github.com/username/repository.git

[palisadoes]

The branch name needs to match in both repos so that it doesn't break in main when we do merges from develop.

[aialok]

The branch name needs to match in both repos so that it doesn't break in main when we do merges from develop.

I need some time to research about how to render dynamically branch name.
I will fix this issue by today afternoon (Indian standard time).

[palisadoes]

The branch name needs to match in both repos so that it doesn't break in main when we do merges from develop.

I need some time to research about how to render dynamically branch name. I will fix this issue by today afternoon (Indian standard time).

1. Ask to be assigned the issue GitHub Action Introspection Test Failure #1429. Issues cannot be assigned to people not participating in the comments section.
2. We'll assign it to the first requester as per our policy

[aialok]

The branch name needs to match in both repos so that it doesn't break in main when we do merges from develop.

@palisadoes please close this issue as it is completed.