Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - Remove Support for Private Organizations #1604

Closed
palisadoes opened this issue Dec 30, 2023 · 8 comments
Closed

API - Remove Support for Private Organizations #1604

palisadoes opened this issue Dec 30, 2023 · 8 comments
Assignees
Labels

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 30, 2023

Is your feature request related to a problem? Please describe.
We need to reduce and simplify some of the Talawa features.

The concept of private organizations is unlikely given that most organizations using Talawa will be non-profits where transparency will be important.

Describe the solution you'd like

Remove all support for private organizations in:

  1. Backend systems and supporting code

Other:

  1. All tests must be valid and pass
  2. No other functionality must be affected.

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context
Related issues include:

  1. API - Remove Support for Private Organizations #1604
  2. Admin - Remove Support for Private Organizations talawa-admin#1327
  3. Mobile - Remove Support for Private Organizations talawa#2287

Potential internship candidates

@AVtheking
Copy link
Contributor

Can I work on this issue ?

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Dec 31, 2023
@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 6, 2024

@AVtheking

  1. What's the status on this?
  2. It's been over a week and we have other PRs dependent on this change being implemented

This was referenced Jan 6, 2024
@AVtheking
Copy link
Contributor

I have created a pr for this please review it.

@AVtheking
Copy link
Contributor

I have created a new pr

@palisadoes
Copy link
Contributor Author

Please refer to this discussion before proceeding

@Farhanpathan0007
Copy link

Is this issue still unresolved, and if so, am I able to take on the task?

@aialok
Copy link
Contributor

aialok commented Jan 14, 2024

@palisadoes, we should update isPublic to 'userRegistrationRequired' in the 'sample-data' and 'schema.graphql' files in talawa-api. Otherwise, it may lead to bugs or test failures, and individuals importing the sample data might encounter difficulties.

Screenshot from 2024-01-14 13-27-21

Screenshot from 2024-01-12 11-38-13

@palisadoes
Copy link
Contributor Author

An issue has been created to fix the DB importation and add it to the GitHub action workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants