Feat/remove private org #1641

AVtheking · 2024-01-06T14:54:05Z

What kind of change does this PR introduce?
Removes support for private organizations

Issue Number:

Fixes #1604

Did you add tests for your changes?
NO

Have you read the contributing guide?
Yes

github-actions · 2024-01-06T14:54:33Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold
Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

codecov · 2024-01-06T15:26:32Z

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (c0468a4) 98.17% compared to head (35a84e3) 97.49%.
Report is 125 commits behind head on develop.

❗ Current head 35a84e3 differs from pull request most recent head 320486e. Consider uploading reports for the commit 320486e to get more accurate results

Files	Patch %	Lines
src/utilities/PII/decryption.ts	0.00%	17 Missing ⚠️
src/resolvers/Mutation/updateUserProfile.ts	70.90%	1 Missing and 15 partials ⚠️
src/resolvers/middleware/currentUserExists.ts	45.83%	13 Missing ⚠️
src/utilities/PII/encryption.ts	0.00%	13 Missing ⚠️
src/utilities/PII/isAuthorised.ts	0.00%	11 Missing ⚠️
src/resolvers/Mutation/createPost.ts	86.95%	6 Missing ⚠️
...tilities/encodedVideoStorage/uploadEncodedVideo.ts	96.29%	3 Missing ⚠️
src/resolvers/Mutation/removeAdvertisement.ts	92.85%	2 Missing ⚠️
...c/resolvers/Query/postsByOrganizationConnection.ts	33.33%	2 Missing ⚠️
src/resolvers/Subscription/onPluginUpdate.ts	0.00%	2 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1641      +/-   ##
===========================================
- Coverage    98.17%   97.49%   -0.69%     
===========================================
  Files          184      214      +30     
  Lines        10767    12948    +2181     
  Branches       835     1041     +206     
===========================================
+ Hits         10571    12624    +2053     
- Misses         186      294     +108     
- Partials        10       30      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

palisadoes · 2024-01-06T17:06:09Z

Merge your code with the latest upstream.

None of the files in the .gitHub directory must be included in this PR. It is out of scope

palisadoes · 2024-01-06T17:07:49Z

The INSTALLATION.md file must not be included in this PR. It is out of scope

…PalisadoesFoundation#1568)" (PalisadoesFoundation#1572) This reverts commit 195d148.

* Replace package vm2 with isolated-vm (PalisadoesFoundation#1532) * Replace package vm2 with isolated-vm * Removed package isolated-vm * Remove unused packages from package.json * Updated Package.json for failing tests

…doesFoundation#1573) * setup script will now ask for superAdmin email * asked changes * Update setup.ts * new commit * new commit * new commit * new commit * new commit * new commit * new commit * new commit * new commit * new commit * new commit

…lisadoesFoundation#1569) * feat: Updated the LAST_RESORT_SUPERADMIN_EMAIL logic during setup * Updated the logic to check superadmin * fix: Resolved a bug in updating the LAST_RESORT_SUPERADMIN_EMAIL logic

* Added script to generate table of content * git hook to generate toc when markdown files are changed. * script for toc

…on#1587)" (PalisadoesFoundation#1592) This reverts commit 74a9f67.

…ation#1616) Bumps [@types/i18n](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/i18n) from 0.13.8 to 0.13.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/i18n) --- updated-dependencies: - dependency-name: "@types/i18n" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…oesFoundation#1615) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.28.1 to 2.29.1. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.28.1...v2.29.1) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ion#1613) Bumps [nodemailer](https://github.com/nodemailer/nodemailer) and [@types/nodemailer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodemailer). These dependencies needed to be updated together. Updates `nodemailer` from 6.9.6 to 6.9.8 - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v6.9.6...v6.9.8) Updates `@types/nodemailer` from 6.4.13 to 6.4.14 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodemailer) --- updated-dependencies: - dependency-name: nodemailer dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: "@types/nodemailer" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…dation#1612) Bumps [@types/bcryptjs](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/bcryptjs) from 2.4.5 to 2.4.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/bcryptjs) --- updated-dependencies: - dependency-name: "@types/bcryptjs" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Akhilender <[email protected]>

* Standardized the location of assets used in markdown files. * git ignoring the markdown assets * ignoring the sub directories * removed public/markdown/*

* fixed cross origin to access images * fixed sample test --------- Co-authored-by: arpitannd <[email protected]>

xoldd · 2024-01-06T17:58:09Z

@palisadoes is a public organization an organization that is publicly available for searching, but it cannot be joined without approval of the admins?

xoldd · 2024-01-06T17:55:46Z

package.json

@@ -48,6 +48,7 @@
    "@graphql-tools/schema": "^10.0.0",
    "@graphql-tools/utils": "^10.0.11",
    "@types/graphql-upload": "^16.0.5",
+    "@types/jwt-decode": "^3.1.0",


get rid of this, jwt-decode provides its own type definitions

xoldd · 2024-01-06T18:00:20Z

src/models/Organization.ts

-  visibleInSearch: {
-    type: Boolean,
-  },
+  // visibleInSearch: {


remove the code instead of just commenting it, same goes all the instances in this PR

I have removed the code

* Added script to generate table of content * git hook to generate toc when markdown files are changed. * script for toc

Signed-off-by: Akhilender <[email protected]>

* Added script to generate table of content * git hook to generate toc when markdown files are changed. * script for toc

…ation#1616) Bumps [@types/i18n](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/i18n) from 0.13.8 to 0.13.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/i18n) --- updated-dependencies: - dependency-name: "@types/i18n" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Akhilender <[email protected]>

src/scripts/githooks/generate-toc.js

+  const filePath = path.join(directory, file);
+
+  // Generating the table of contents
+  execSync(`markdown-toc -i ${filePath}`);


AVtheking · 2024-01-06T19:14:42Z

I have created another pr for this please review that

palisadoes · 2024-01-06T20:03:21Z

No. This PR must remain.

We have a history here and we now need to find reviewers again.

It is also against the correct branch.

Please be considerate of our volunteers time.

There is no reason to choose this at all

palisadoes · 2024-01-06T20:04:02Z

I'm reopening and closing whichever one you reopen.

This is in such bad form.

Please do not do this again. Our videos expressly explain why this is a bad idea

AVtheking · 2024-01-06T20:12:44Z

Sorry sir for the inconveniences but because of the huge no of conflicts I have to delete and re upload the branch, that's why I have raised another pr

palisadoes · 2024-01-06T20:16:32Z

Sorry sir for the inconveniences but because of the huge no of conflicts I have to delete and re upload the branch, that's why I have raised another pr

You could still do it with the existing PR and branch.

I'll reopen it soon

AVtheking · 2024-01-06T20:17:20Z

Ok sir

Cioppolo14 · 2024-01-06T20:33:09Z

@AVtheking We cannot reopen the PR. Please open a new one, and then do not close it. Do not close a PR in the future unless your reviewers explicitly request that. This has created a lot of extra work for our team.

AVtheking and others added 5 commits December 25, 2023 22:10

updated node version

03d1451

Merge branch 'develop' into fix/upgrade_to_Node_20(LTS)

a396178

deleted video file

6d1769e

fix falling test

570dbd3

removed private org

2aa975a

AVtheking requested a review from palisadoes as a code owner January 6, 2024 14:54

AVtheking added 2 commits January 6, 2024 20:25

fix redis port

35203e0

fix failing test case

35a84e3

palisadoes requested review from xoldd, DMills27 and sumitra19jha January 6, 2024 16:55

palisadoes and others added 15 commits January 6, 2024 23:23

Revert "restored countline.py functionality to our github action flow (…

d3e6ea3

…PalisadoesFoundation#1568)" (PalisadoesFoundation#1572) This reverts commit 195d148.

Update CONTRIBUTING.md

f269687

feat: Updated the LAST_RESORT_SUPERADMIN_EMAIL logic during setup (Pa…

fdbff9a

…lisadoesFoundation#1569) * feat: Updated the LAST_RESORT_SUPERADMIN_EMAIL logic during setup * Updated the logic to check superadmin * fix: Resolved a bug in updating the LAST_RESORT_SUPERADMIN_EMAIL logic

Added script to generate table of content (PalisadoesFoundation#1587)

68c57c6

* Added script to generate table of content * git hook to generate toc when markdown files are changed. * script for toc

Revert "Added script to generate table of content (PalisadoesFoundati…

2a1dced

…on#1587)" (PalisadoesFoundation#1592) This reverts commit 74a9f67.

table of content script (PalisadoesFoundation#1600)

a10ba34

Update INSTALLATION.md

4801fff

updated express-rate-limit package (PalisadoesFoundation#1621)

c8500cc

fix: Removed depricated xss-clean package (PalisadoesFoundation#1536)

1a06b42

Signed-off-by: Akhilender <[email protected]>

Veer0x1 and others added 6 commits January 6, 2024 23:23

Standardized the assets (PalisadoesFoundation#1630)

9f6415f

* Standardized the location of assets used in markdown files. * git ignoring the markdown assets * ignoring the sub directories * removed public/markdown/*

Fixes access to image from the frontend (PalisadoesFoundation#1631)

8266774

* fixed cross origin to access images * fixed sample test --------- Co-authored-by: arpitannd <[email protected]>

updated node version

10b9b9b

fix falling test

ee6b98a

fix

1dc90a4

Merge branch 'develop' into feat/remove_private_org

fc3e019

xoldd reviewed Jan 6, 2024

View reviewed changes

Veer0x1 and others added 9 commits January 7, 2024 00:07

Added script to generate table of content (PalisadoesFoundation#1587)

76fb6bb

* Added script to generate table of content * git hook to generate toc when markdown files are changed. * script for toc

fix: Removed depricated xss-clean package (PalisadoesFoundation#1536)

34feaaf

Signed-off-by: Akhilender <[email protected]>

Added script to generate table of content (PalisadoesFoundation#1587)

70ea814

* Added script to generate table of content * git hook to generate toc when markdown files are changed. * script for toc

table of content script (PalisadoesFoundation#1600)

1014611

Update INSTALLATION.md

aee1c1d

fix: Removed depricated xss-clean package (PalisadoesFoundation#1536)

c83bf20

Signed-off-by: Akhilender <[email protected]>

updated node version

93235ba

removed comments

1deea6d

github-advanced-security bot found potential problems Jan 6, 2024

View reviewed changes

AVtheking added 2 commits January 7, 2024 00:14

fix

e454acc

fix

320486e

AVtheking closed this Jan 6, 2024

AVtheking deleted the feat/remove_private_org branch January 6, 2024 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/remove private org #1641

Feat/remove private org #1641

AVtheking commented Jan 6, 2024

github-actions bot commented Jan 6, 2024

codecov bot commented Jan 6, 2024 •

edited

Loading

palisadoes commented Jan 6, 2024

palisadoes commented Jan 6, 2024

xoldd commented Jan 6, 2024

xoldd Jan 6, 2024

xoldd Jan 6, 2024

AVtheking Jan 6, 2024

AVtheking commented Jan 6, 2024

palisadoes commented Jan 6, 2024

palisadoes commented Jan 6, 2024 •

edited

Loading

AVtheking commented Jan 6, 2024

palisadoes commented Jan 6, 2024

AVtheking commented Jan 6, 2024

Cioppolo14 commented Jan 6, 2024

Feat/remove private org #1641

Feat/remove private org #1641

Conversation

AVtheking commented Jan 6, 2024

github-actions bot commented Jan 6, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

codecov bot commented Jan 6, 2024 • edited Loading

Codecov Report

palisadoes commented Jan 6, 2024

palisadoes commented Jan 6, 2024

xoldd commented Jan 6, 2024

xoldd Jan 6, 2024

Choose a reason for hiding this comment

xoldd Jan 6, 2024

Choose a reason for hiding this comment

AVtheking Jan 6, 2024

Choose a reason for hiding this comment

AVtheking commented Jan 6, 2024

palisadoes commented Jan 6, 2024

palisadoes commented Jan 6, 2024 • edited Loading

AVtheking commented Jan 6, 2024

palisadoes commented Jan 6, 2024

AVtheking commented Jan 6, 2024

Cioppolo14 commented Jan 6, 2024

codecov bot commented Jan 6, 2024 •

edited

Loading

palisadoes commented Jan 6, 2024 •

edited

Loading