Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr workflow #1161

Merged
merged 3 commits into from
Dec 10, 2023
Merged

Conversation

duplixx
Copy link
Member

@duplixx duplixx commented Dec 7, 2023

What kind of change does this PR introduce?

Feature added
Added feature to only check the files which have been changed

Issue Number:

Fixes #1117

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

@duplixx duplixx requested a review from palisadoes as a code owner December 7, 2023 17:57
Copy link

github-actions bot commented Dec 7, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@noman2002
Copy link
Member

Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details.

Please also fill in the template for the pull request as completely as you can. It greatly helps others searching for code changes in future and helps others understand the summarized rationale for the work you have done

@tasneemkoushar
Copy link
Contributor

@duplixx please resolve the conflicting files.

@duplixx
Copy link
Member Author

duplixx commented Dec 9, 2023

@noman2002 @tasneemkoushar fixed the failing issue kindly check !!
thanks!

@tasneemkoushar tasneemkoushar merged commit 5a475c8 into PalisadoesFoundation:develop Dec 10, 2023
4 of 6 checks passed
palisadoes added a commit that referenced this pull request Dec 12, 2023
@palisadoes palisadoes mentioned this pull request Dec 12, 2023
palisadoes added a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants