fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx #1165

meetulr · 2023-12-08T14:59:53Z

What kind of change does this PR introduce?

Added code coverage for src/screens/OrgPost/OrgPost.test.tsx

Issue Number:

Fixes #1136
Fixes #1029

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

github-actions · 2023-12-08T15:00:22Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold
Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

aashimawadhwa · 2023-12-08T17:13:05Z

Thanks.

Please also get the test code coverage for the typescript files you edited up to 100%

We are trying to get back up to 95% coverage overall to ensure the reliability of our code.
@meetulr

meetulr · 2023-12-09T05:08:05Z

Thanks.

Please also get the test code coverage for the typescript files you edited up to 100%

We are trying to get back up to 95% coverage overall to ensure the reliability of our code. @meetulr

A test is failing because of incomplete code coverage in components outside the scope of this issue.
The coverage of src/screens/OrgPost/OrgPost.test.tsx (which is the file related to the assigned issue) is now 100%, after i made the necessary changes. I didn't change any other component or it's test file.
I've had this problem with another pull request too #1150. That pr has been merged.

aashimawadhwa · 2023-12-09T16:17:41Z

The test are failling due to the code in this file itself, you can check the report here @meetulr

meetulr · 2023-12-09T17:07:40Z

The test are failling due to the code in this file itself, you can check the report here @meetulr

Yes, that's what i meant. The file in the linked report is src/components/OrgPostCard/OrgPostCard.tsx, and the file associated with this issue is src/screens/OrgPost/OrgPost.tsx #1136. The test is failing because of incomplete coverage in other component files. Those components have their separate issues open which are assigned to other contributors.
Same case with my last pr #1150, which was merged despite that one test failing.
What should I do?

palisadoes · 2023-12-09T17:13:13Z

The test are failling due to the code in this file itself, you can check the report here @meetulr

Yes, that's what i meant. The file in the linked report is src/components/OrgPostCard/OrgPostCard.tsx, and the file associated with this issue is src/screens/OrgPost/OrgPost.tsx #1136. The test is failing because of incomplete coverage in other component files. Those components have their separate issues open which are assigned to other contributors. Same case with my last pr #1150, which was merged despite that one test failing. What should I do?

Comment on this issue for that file so that we can assign it to you. Fix both issues with this PR.

Code Coverage: Create tests for src/components/OrgPostCard/OrgPostCard.tsx #1029

palisadoes · 2023-12-09T17:19:47Z

According to the code coverage report this PR will get us over 95% coverage which will stop the errors in future.

This PR was supposed to get us over 95% which is why it was merged with the error failure. 95% coverage is our goal.

fix: improve code coverage for src/components/Advertisements/core/Adv… #1150

Why do you think the coverage isn't crossing the threshold?

meetulr · 2023-12-09T17:26:02Z

The test are failling due to the code in this file itself, you can check the report here @meetulr

Yes, that's what i meant. The file in the linked report is src/components/OrgPostCard/OrgPostCard.tsx, and the file associated with this issue is src/screens/OrgPost/OrgPost.tsx #1136. The test is failing because of incomplete coverage in other component files. Those components have their separate issues open which are assigned to other contributors. Same case with my last pr #1150, which was merged despite that one test failing. What should I do?

Comment on this issue for that file so that we can assign it to you. Fix both issues with this PR.

Code Coverage: Create tests for src/components/OrgPostCard/OrgPostCard.tsx #1029

I have commented on that issue, i'll try to fix that and see if the tests are passing then.

palisadoes · 2023-12-09T17:35:20Z

I spoke too soon. I wasn't paying sufficient attention.

Yes, the patch is may have 100% coverage but the overall code base has 94.7% coverage.
The behaviour of CodeCov seems to have changed. The GitHub pull request CodeCov report passes with tick marks, but fails in the testing workflow.
It also seems that the reporting is incorrect in other ways, because this is not the first time I've seen that the PR would improve the code coverage by an amount to get us over our 95% target, with the coverage not exceeding 95% afterwards.

In the past CodeCov has been similarly temperamental, so we have been merging test PRs for the sake of speed expecting the overall coverage to be under 95% We will be more stringent after we reach this goal.

palisadoes · 2023-12-09T17:41:29Z

Please post the code coverage for the file you are testing in the PR to prove you have reached 100%.
Based on the online report it looks like it is only 95.08%

meetulr · 2023-12-09T18:56:36Z

Please post the code coverage for the file you are testing in the PR to prove you have reached 100%.

Based on the online report it looks like it is only 95.08%

Sure, if we look at the details of the test that has failed here it shows us exactly what lines were missing coverage and in what components, at the time I committed.
As we can see, it shows no missing lines for src/screens/OrgPost/OrgPost.tsx.
As for the 95.08% coverage, I think it's covering multiple files between the two commits. The change of +1.94% is because of the file I changed.

codecov · 2023-12-09T19:25:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad70522) 94.77% compared to head (e2be9a8) 95.46%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1165      +/-   ##
===========================================
+ Coverage    94.77%   95.46%   +0.69%     
===========================================
  Files          138      138              
  Lines         3327     3328       +1     
  Branches       923      923              
===========================================
+ Hits          3153     3177      +24     
+ Misses         167      144      -23     
  Partials         7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

palisadoes · 2023-12-09T19:27:23Z

I've asked some others to review this and merge if acceptable.

…d.tsx

meetulr · 2023-12-10T15:05:05Z

Ok... now it's passing all the tests, the coverage is 100% for both the files (issues #1136 & #1029).

noman2002

LGTM

meetulr · 2023-12-10T15:36:20Z

Oops!!, I accidentally clicked the refresh button which sent out another review request to you @noman2002. Please ignore it. My apologies for the confusion.

SiddheshKukade assigned meetulr Dec 9, 2023

SiddheshKukade added the area/tests label Dec 9, 2023

SiddheshKukade requested a review from aashimawadhwa December 9, 2023 02:34

PalisadoesFoundation deleted a comment from codecov bot Dec 9, 2023

palisadoes requested review from noman2002 and EshaanAgg December 9, 2023 19:26

meetulr added 2 commits December 10, 2023 15:04

fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx

d285bbd

fix: improved code coverage for src/components/OrgPostCard/OrgPostCar…

e2be9a8

…d.tsx

meetulr force-pushed the issue1136 branch from e1b06e6 to e2be9a8 Compare December 10, 2023 13:40

noman2002 approved these changes Dec 10, 2023

View reviewed changes

meetulr requested a review from noman2002 December 10, 2023 15:32

noman2002 approved these changes Dec 10, 2023

View reviewed changes

palisadoes approved these changes Dec 10, 2023

View reviewed changes

palisadoes merged commit 73df92c into PalisadoesFoundation:develop Dec 10, 2023
7 checks passed

meetulr deleted the issue1136 branch December 10, 2023 17:17

meetulr mentioned this pull request Dec 27, 2023

Code Coverage: Create tests for src/components/OrgPostCard/OrgPostCard.tsx #1029

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx #1165

fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx #1165

meetulr commented Dec 8, 2023 •

edited

Loading

github-actions bot commented Dec 8, 2023

aashimawadhwa commented Dec 8, 2023

meetulr commented Dec 9, 2023

aashimawadhwa commented Dec 9, 2023 •

edited

Loading

meetulr commented Dec 9, 2023 •

edited

Loading

palisadoes commented Dec 9, 2023

palisadoes commented Dec 9, 2023 •

edited

Loading

meetulr commented Dec 9, 2023 •

edited

Loading

palisadoes commented Dec 9, 2023

palisadoes commented Dec 9, 2023

meetulr commented Dec 9, 2023 •

edited

Loading

codecov bot commented Dec 9, 2023 •

edited

Loading

palisadoes commented Dec 9, 2023

meetulr commented Dec 10, 2023 •

edited

Loading

noman2002 left a comment

meetulr commented Dec 10, 2023

fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx #1165

fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx #1165

Conversation

meetulr commented Dec 8, 2023 • edited Loading

github-actions bot commented Dec 8, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

aashimawadhwa commented Dec 8, 2023

meetulr commented Dec 9, 2023

aashimawadhwa commented Dec 9, 2023 • edited Loading

meetulr commented Dec 9, 2023 • edited Loading

palisadoes commented Dec 9, 2023

palisadoes commented Dec 9, 2023 • edited Loading

meetulr commented Dec 9, 2023 • edited Loading

palisadoes commented Dec 9, 2023

palisadoes commented Dec 9, 2023

meetulr commented Dec 9, 2023 • edited Loading

codecov bot commented Dec 9, 2023 • edited Loading

Codecov Report

palisadoes commented Dec 9, 2023

meetulr commented Dec 10, 2023 • edited Loading

noman2002 left a comment

Choose a reason for hiding this comment

meetulr commented Dec 10, 2023

meetulr commented Dec 8, 2023 •

edited

Loading

aashimawadhwa commented Dec 9, 2023 •

edited

Loading

meetulr commented Dec 9, 2023 •

edited

Loading

palisadoes commented Dec 9, 2023 •

edited

Loading

meetulr commented Dec 9, 2023 •

edited

Loading

meetulr commented Dec 9, 2023 •

edited

Loading

codecov bot commented Dec 9, 2023 •

edited

Loading

meetulr commented Dec 10, 2023 •

edited

Loading