-
-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated pagination.spec.tsx from jest to vitest #2949
Migrated pagination.spec.tsx from jest to vitest #2949
Conversation
WalkthroughThe pull request focuses on migrating the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Learnings (2)📓 Common learnings
src/components/Pagination/Pagination.spec.tsx (1)
🔇 Additional comments (3)src/components/Pagination/Pagination.spec.tsx (3)
The import of Vitest functions (
Using
The second test case is also appropriately migrated to Vitest. No additional changes needed. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2949 +/- ##
=====================================================
+ Coverage 41.84% 88.39% +46.54%
=====================================================
Files 299 316 +17
Lines 7422 8273 +851
Branches 1624 1869 +245
=====================================================
+ Hits 3106 7313 +4207
+ Misses 4106 742 -3364
- Partials 210 218 +8 ☔ View full report in Codecov by Sentry. |
@palisadoes Kindly review the pr. |
f017c5d
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Migrated the file
src/components/Pagination/Pagination.spec.tsx
from jest to vitest.Issue Number:
Fixes #2818
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Pagination
component to enhance test case clarity and maintainability.