Using Global CSS root variables across all files #3014

AceHunterr · 2024-12-28T21:43:24Z

What kind of change does this PR introduce?
Feature, more like providing consistency

Issue Number:
Fixes #2983

Did you add tests for your changes?
No

Snapshots/Videos:
The files whose styles are moved to global css module i.e - src/style/app.module.css were looked upon and if those files had common standard css styling needed they were replaced by the root css vars. Currently only these files have been refactored with global css yet so these were looked upon:

Summary

Does this PR introduce a breaking change?
No

Have you read the contributing guide?
Yes

Summary by CodeRabbit

Style Updates
- Replaced hardcoded color values with CSS variables across multiple components for improved styling consistency.
- Added new CSS variable --primary-border-solid for standardized border styling.
- Updated border and background colors in components like AddOnEntry, EventAttendance, VolunteerGroupViewModal, ManageTag, and OrganizationTags.
Code Cleanup
- Removed commented-out code in Requests and AddOnEntry components.
- Simplified import statements in EventRegistrants component.
Minor Improvements
- Enhanced error handling in OrgList component.
- Refined organization search and loading functionality.

coderabbitai · 2024-12-28T21:43:31Z

Walkthrough

This pull request focuses on enhancing styling consistency across multiple components by replacing hardcoded color values with CSS root variables. The changes span several files in the project, primarily updating border colors, background colors, and other styling properties to use global CSS variables. The modifications aim to improve maintainability and provide a more centralized approach to styling management.

Changes

File	Change Summary
`src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx`	Updated border style to use CSS variable `var(--primary-border-solid)` and removed commented-out switch code.
`src/components/EventManagement/EventAttendance/EventAttendance.tsx`	Modified tooltip styling using CSS variables for background and border.
`src/components/EventManagement/EventRegistrant/EventRegistrants.tsx`	Renamed CSS module import from `style` to `styles`.
`src/screens/EventVolunteers/VolunteerGroups/VolunteerGroupViewModal.tsx`	Changed label color to CSS variable `var(--search-button-border)`.
`src/screens/ManageTag/ManageTag.tsx`	Updated `<hr>` border color to `var(--grey-border-box-color)`.
`src/screens/OrgList/OrgList.tsx`	Refined import organization and enhanced error handling.
`src/screens/OrganizationTags/OrganizationTags.tsx`	Updated DataGrid styling with CSS variables for background and border radius.
`src/screens/Requests/Requests.tsx`	Removed commented-out style property.
`src/style/app.module.css`	Added new CSS variable `--primary-border-solid`.

Assessment against linked issues

Objective	Addressed	Explanation
Replace hardcoded style values with global CSS root variables [#2983]	✅
Improve CSS consistency across components	✅

Possibly related issues

Refactor CSS files in src/screens/Requests #2525: Refactoring CSS files in src/screens/Requests, which aligns with the current PR's approach to CSS standardization.
Refactor CSS files in src/screens/EventManagement #2504: Refactoring CSS files in src/screens/EventManagement, similar to the styling improvements in this PR.
Refactor CSS files in src/screens/ManageTag #2510: Refactoring CSS files in src/screens/ManageTag, consistent with the current PR's styling updates.

Possibly related PRs

Chore/organization people UI changes #2358: This PR involves updates to CSS variables, which is relevant to the main PR's changes to the AddOnEntry component that also utilizes CSS variables for styling.
changed color schema for the tag and action item screen #2417: This PR updates CSS variables for styling in the ItemModal component, which aligns with the main PR's focus on improving maintainability through CSS variables in the AddOnEntry component.
fixed:#2510 Refactor CSS files in src/screens/ManageTag #2769: This PR refactors CSS files in the ManageTag component, which is relevant to the main PR's focus on improving CSS structure and maintainability.

Suggested labels

ignore-sensitive-files-pr

Suggested reviewers

palisadoes

Poem

🐰 Styling rabbits hop with glee,
CSS variables set our colors free!
No more hardcoded hues so bright,
Global roots make everything just right!
A rainbow of consistency we weave 🌈

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3c33e8 and 1932dea.

📒 Files selected for processing (3)

src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx (1 hunks)
src/components/EventManagement/EventAttendance/EventAttendance.tsx (1 hunks)
src/style/app.module.css (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx
src/components/EventManagement/EventAttendance/EventAttendance.tsx
src/style/app.module.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-28T21:43:48Z

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

We don't merge PRs with poor code quality.
1. Follow coding best practices such that CodeRabbit.ai approves your PR.
We don't merge PRs with failed tests.
1. When tests fail, click on the Details link to learn more.
2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

AceHunterr · 2024-12-28T21:52:32Z

@palisadoes Since we are still in the transition of making a global css file for all I see many repeated css style which are not used as variable for example:

I did a global search and found this style being used 7-8 places in the code
border : 1px solid #31bb6b
So I basically created --primary-border-green: 1px solid #31bb6b; as a root variable in the CSS file

But the issue lies that out of these 7-8 files only 1 was refactored with our single global css file. So unless all the other files are not refactored we won't be able to use the style inside them.

Although it won't be much time consuming issue once all files are refactored... if I would change them right now it would cause a lot of merge conflicts to the already assigned assignees. So I would request that you may merge this PR upon reviewing but the issue will have to be open for sometime I guess.

codecov · 2024-12-28T21:55:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (2e18c32) to head (1932dea).
Report is 1 commits behind head on develop-postgres.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           develop-postgres    #3014       +/-   ##
=====================================================
+ Coverage             29.13%   88.95%   +59.81%     
=====================================================
  Files                   300      321       +21     
  Lines                  7568     8409      +841     
  Branches               1652     1894      +242     
=====================================================
+ Hits                   2205     7480     +5275     
+ Misses                 5177      686     -4491     
- Partials                186      243       +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

palisadoes

See comment

src/style/app.module.css

AVtheking · 2024-12-29T12:47:16Z

Please fix the conficting files.

AceHunterr · 2024-12-29T13:47:33Z

Please fix the conficting files.

Done

palisadoes · 2024-12-29T15:12:13Z

Please address the green coloration I mentioned previously.

AceHunterr · 2024-12-29T15:38:05Z

Please address the green coloration I mentioned previously.

I was looking for the alternate color in the PR mentioned

--dropdown-border-color: #555555;

then I used this color for the alternative as most of the borders were using this in the code... is it good to go?

palisadoes · 2024-12-29T15:43:23Z

That should work. It's sufficiently dark

…n#3014) * Using Global CSS root variables across all files * Removed green color

Using Global CSS root variables across all files

2a54e44

Merge branch 'develop-postgres' into Issue#2983

38bd94a

coderabbitai bot previously approved these changes Dec 28, 2024

View reviewed changes

palisadoes requested changes Dec 28, 2024

View reviewed changes

src/style/app.module.css Outdated Show resolved Hide resolved

Merge branch 'develop-postgres' into Issue#2983

f3c33e8

AceHunterr dismissed coderabbitai[bot]’s stale review via f3c33e8 December 29, 2024 13:46

coderabbitai bot previously approved these changes Dec 29, 2024

View reviewed changes

conflict prior code

7d5e81c

AceHunterr added 2 commits December 29, 2024 20:45

Removed green color

fd34b66

Removed green color

1932dea

AceHunterr dismissed coderabbitai[bot]’s stale review via 1932dea December 29, 2024 15:30

coderabbitai bot approved these changes Dec 29, 2024

View reviewed changes

palisadoes approved these changes Dec 29, 2024

View reviewed changes

palisadoes merged commit 78699b3 into PalisadoesFoundation:develop-postgres Dec 29, 2024
15 checks passed

coderabbitai bot mentioned this pull request Dec 30, 2024

Feat/css #3084

Merged

Dhiren-Mhatre pushed a commit to Dhiren-Mhatre/talawa-admin that referenced this pull request Dec 30, 2024

Using Global CSS root variables across all files (PalisadoesFoundatio…

8ad94bd

…n#3014) * Using Global CSS root variables across all files * Removed green color

This was referenced Dec 31, 2024

refactor VolunteerViewModal-css #3085

Closed

refactor: admin-doc to hasura docs style #3098

Closed

Feature/admin docs refactor/admin-doc to hashura docs style #3100

Merged

AceHunterr deleted the Issue#2983 branch January 8, 2025 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using Global CSS root variables across all files #3014

Using Global CSS root variables across all files #3014

AceHunterr commented Dec 28, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 28, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 28, 2024

AceHunterr commented Dec 28, 2024

codecov bot commented Dec 28, 2024 •

edited

Loading

palisadoes left a comment

AVtheking commented Dec 29, 2024

AceHunterr commented Dec 29, 2024

palisadoes commented Dec 29, 2024

AceHunterr commented Dec 29, 2024

palisadoes commented Dec 29, 2024

Using Global CSS root variables across all files #3014

Using Global CSS root variables across all files #3014

Conversation

AceHunterr commented Dec 28, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 28, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 28, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

AceHunterr commented Dec 28, 2024

codecov bot commented Dec 28, 2024 • edited Loading

Codecov Report

palisadoes left a comment

Choose a reason for hiding this comment

AVtheking commented Dec 29, 2024

AceHunterr commented Dec 29, 2024

palisadoes commented Dec 29, 2024

AceHunterr commented Dec 29, 2024

palisadoes commented Dec 29, 2024

AceHunterr commented Dec 28, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 28, 2024 •

edited

Loading

codecov bot commented Dec 28, 2024 •

edited

Loading